Skip to content

Commit 5911890

Browse files
Merge branch 'main' into user-settings-appearance-view
2 parents d76c408 + 7cbf0a7 commit 5911890

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

packages/fiori/src/UserMenuTemplate.tsx

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default function UserMenuTemplate(this: UserMenu) {
2929
horizontalAlign="End"
3030
tabindex={-1}
3131
accessibleName={this.accessibleNameText}
32-
aria-labelledby={this.accessibleNameText}
32+
aria-label={this.accessibleNameText}
3333
open={this.open}
3434
opener={this.opener}
3535
onClose={this._handlePopoverAfterClose}
@@ -94,13 +94,13 @@ export default function UserMenuTemplate(this: UserMenu) {
9494
function headerContent(this: UserMenu) {
9595
return (<>
9696
{this._selectedAccount &&
97-
<div class="ui5-user-menu-selected-account" aria-labelledby={this._ariaLabelledByAccountInformationText}>
97+
<div class="ui5-user-menu-selected-account" aria-label={this._ariaLabelledByAccountInformationText}>
9898
<Avatar size="L" onClick={this._handleAvatarClick} initials={this._selectedAccount._initials} fallbackIcon={personPlaceholder} class="ui5-user-menu--selected-account-avatar" interactive>
9999
{this._selectedAccount.avatarSrc &&
100-
<img src={this._selectedAccount.avatarSrc}/>
100+
<img src={this._selectedAccount.avatarSrc} title={this.showEditButton ? this._editAvatarTooltip : undefined }/>
101101
}
102102
{this.showEditButton &&
103-
<Tag slot="badge" wrappingType="None" design="Set1" colorScheme="5" title={this._editAvatarTooltip}>
103+
<Tag slot="badge" wrappingType="None" design="Set1" colorScheme="5" >
104104
<Icon slot="icon" name={edit}></Icon>
105105
</Tag>
106106
}
@@ -129,7 +129,7 @@ function headerContent(this: UserMenu) {
129129

130130
function otherAccountsContent(this: UserMenu) {
131131
return (<>
132-
<Panel collapsed={true} class="ui5-user-menu-other-accounts" aria-labelledby={this._otherAccountsButtonText}>
132+
<Panel collapsed={true} class="ui5-user-menu-other-accounts" aria-label={this._otherAccountsButtonText}>
133133
<div slot="header" class="ui5-user-menu-account-header">
134134
<Title slot="header" level="H4" wrapping-type="None">{this._otherAccountsButtonText} ({this._otherAccounts.length})</Title>
135135
{this.showEditAccounts &&
@@ -147,15 +147,16 @@ function otherAccountsContent(this: UserMenu) {
147147

148148
function otherAccountsList(this: UserMenu) {
149149
return (<>
150-
<List onItemClick={this._handleAccountSwitch} aria-labelledby={this._ariaLabelledByActions} loadingDelay={0}
150+
<List onItemClick={this._handleAccountSwitch} aria-label={this._ariaLabelledByActions} loadingDelay={0}
151151
loading={this._otherAccounts.some(account => account.loading === true)}>
152152
{this._otherAccounts.map((account, index) =>
153153
<ListItemCustom
154154
ref={this.captureRef.bind(account)}
155-
aria-labelledby={account.titleText}
156-
aria-possition={index + 1}
157-
aria-setsize={this._otherAccounts.length}
158-
aria-dectiption={this.getAccountDescriptionText(account)}
155+
accessibilityAttributes={{
156+
"ariaPosinset": index + 1,
157+
"ariaSetsize": this._otherAccounts.length
158+
}}
159+
aria-label={account.titleText}
159160
>
160161
<div class="ui5-user-menu-other-accounts-content">
161162
<Avatar slot="image" size="S" initials={account._initials} fallbackIcon={personPlaceholder}>

0 commit comments

Comments
 (0)