Skip to content

Commit 5a09d24

Browse files
committed
fix(ui5-combobox): use Title component for dialog header to match MultiComboBox
1 parent 8953aee commit 5a09d24

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

packages/main/cypress/specs/ComboBox.mobile.cy.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ describe("Dialog header title", () => {
645645

646646
cy.get("#myCB")
647647
.shadow()
648-
.find("[ui5-responsive-popover] .ui5-responsive-popover-header .row span")
648+
.find("[ui5-responsive-popover] .ui5-responsive-popover-header-text")
649649
.should("have.text", "Country");
650650
});
651651

@@ -666,7 +666,7 @@ describe("Dialog header title", () => {
666666

667667
cy.get("#myCB")
668668
.shadow()
669-
.find("[ui5-responsive-popover] .ui5-responsive-popover-header .row span")
669+
.find("[ui5-responsive-popover] .ui5-responsive-popover-header-text")
670670
.should("have.text", INPUT_SUGGESTIONS_TITLE.defaultText);
671671
});
672672
});

packages/main/src/ComboBoxPopoverTemplate.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Icon from "./Icon.js";
22
import Button from "./Button.js";
33
import List from "./List.js";
44
import Input from "./Input.js";
5+
import Title from "./Title.js";
56
import PopoverHorizontalAlign from "./types/PopoverHorizontalAlign.js";
67
import Popover from "./Popover.js";
78
import ResponsivePopover from "./ResponsivePopover.js";
@@ -40,7 +41,13 @@ export default function ComboBoxPopoverTemplate(this: ComboBox) {
4041
<>
4142
<div slot="header" class="ui5-responsive-popover-header">
4243
<div class="row">
43-
<span>{this._headerTitleText}</span>
44+
<Title
45+
level="H1"
46+
wrappingType="None"
47+
class="ui5-responsive-popover-header-text"
48+
>
49+
{this._headerTitleText}
50+
</Title>
4451
</div>
4552

4653
<div class="row">

0 commit comments

Comments
 (0)