Skip to content

Commit 6542b79

Browse files
committed
chore: remove eslint
1 parent c77fecb commit 6542b79

13 files changed

Lines changed: 46 additions & 296 deletions

File tree

docs/09-migration-guides/02-to-version-3.md

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,3 +98,48 @@ CSS custom properties (`--ui5-*`) are no longer scoped with the package version
9898
>
9999
> If you relied on versioned variable names for multi-version isolation, you will need to implement an alternative strategy (e.g. CSS layer scoping or shadow DOM containment).
100100
101+
---
102+
103+
### ESLint support removed
104+
105+
The built-in ESLint runner and shared ESLint configuration have been removed from `@ui5/webcomponents-tools`. The following are no longer provided:
106+
107+
| Removed item | Details |
108+
|---|---|
109+
| `lib/eslint/eslint.cjs` | ESLint runner script |
110+
| `components-package/eslint.cjs` | Shared ESLint configuration (airbnb-base + TypeScript overrides) |
111+
| NPS script `lint` | Ran ESLint on the package source |
112+
| NPS script `lintfix` | Ran ESLint with `--fix` |
113+
| `eslint`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-no-leaked-values` | ESLint npm dependencies |
114+
| `@typescript-eslint/eslint-plugin`, `@typescript-eslint/parser` | TypeScript ESLint dependencies |
115+
116+
> **What to do:** Set up ESLint directly in your project. Remove any `.eslintrc.cjs` file that extended `@ui5/webcomponents-tools/components-package/eslint.js` — it is no longer available.
117+
>
118+
> For guidance on setting up ESLint with TypeScript support in a web components project, refer to the [ESLint documentation](https://eslint.org/docs/latest/) and the [@typescript-eslint getting started guide](https://typescript-eslint.io/getting-started/).
119+
120+
---
121+
122+
### Package converted to native ESM (`"type": "module"`)
123+
124+
`@ui5/webcomponents-tools` is now a native ES module package. All files use ESM syntax (`import`/`export`) and the package has `"type": "module"` in its `package.json`.
125+
126+
**`package-scripts.cjs` must be renamed and converted to ESM**
127+
128+
If your package has a `package-scripts.cjs` file, rename it to `package-scripts.js` and convert it to ESM syntax:
129+
130+
```js
131+
// Before (package-scripts.cjs — CommonJS)
132+
const getScripts = require("@ui5/webcomponents-tools/components-package/nps.js");
133+
module.exports = { scripts: getScripts({ ... }) };
134+
```
135+
136+
```js
137+
// After (package-scripts.js — ESM)
138+
import getScripts from "@ui5/webcomponents-tools/components-package/nps.js";
139+
export default { scripts: getScripts({ ... }) };
140+
```
141+
142+
**`.mjs` entry points renamed to `.js`**
143+
144+
All files that were previously published with a `.mjs` extension are now `.js`. If you imported any of these directly (e.g. from `lib/css-processors/` or `lib/dev-server/`), update the extension in your imports.
145+

packages/ai/.eslintrc.cjs

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/base/.eslintrc.cjs

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/base/package-scripts.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ const scripts = {
2929
"generated": `ui5nps-script "${LIB}/rimraf/rimraf.js src/generated`,
3030
"dist": `ui5nps-script "${LIB}/rimraf/rimraf.js dist`,
3131
},
32-
lint: `ui5nps-script "${LIB}/eslint/eslint.cjs"`,
3332
generate: "ui5nps clean build.i18n integrate copy generateAssetParameters generateVersionInfo generateStyles generateFontFace build.jsonImports",
3433
prepare: "ui5nps clean build.i18n integrate copy generateAssetParameters generateVersionInfo generateStyles generateFontFace typescript integrate.no-remaining-require build.jsonImports",
3534
typescript: "tsc -b",

packages/compat/.eslintrc.cjs

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/fiori/.eslintrc.cjs

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/localization/.eslintrc.cjs

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/localization/package-scripts.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const scripts = {
1818
"generated": `ui5nps-script "${LIB}/rimraf/rimraf.js src/generated`,
1919
"dist": `ui5nps-script "${LIB}/rimraf/rimraf.js dist`,
2020
},
21-
lint: `ui5nps-script "${LIB}eslint/eslint.cjs"`,
2221
generate: "ui5nps clean copy.used-modules copy.cldr copy.overlay build.amd-to-es6 build.jsonImports",
2322
build: {
2423
"default": "ui5nps clean copy.used-modules copy.cldr copy.overlay build.amd-to-es6 build.jsonImports build.typescript build.no-remaining-require",

packages/main/.eslintrc.cjs

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/tools/components-package/eslint.cjs

Lines changed: 0 additions & 195 deletions
This file was deleted.

0 commit comments

Comments
 (0)