Skip to content

Commit 6d2f572

Browse files
authored
fix(ui5-date-range-picker): stabilize tests (#13432)
This PR stabilizes the ui5-date-range-picker Cypress tests by adding proper assertions to ensure elements exist before interacting with them.
1 parent 1bfa9ee commit 6d2f572

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

packages/main/cypress/specs/DateRangePicker.cy.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,10 +1394,18 @@ describe("DateRangePicker - Two Calendars Feature", () => {
13941394

13951395
cy.realPress("Space");
13961396

1397+
cy.get<DateRangePicker>("@dateRangePicker")
1398+
.ui5DateRangePickerGetCalendar()
1399+
.shadow()
1400+
.find("[ui5-monthpicker]")
1401+
.should("exist")
1402+
.should("not.have.attr", "hidden");
1403+
13971404
cy.get<DateRangePicker>("@dateRangePicker")
13981405
.ui5DateRangePickerGetCalendar()
13991406
.shadow()
14001407
.find(".ui5-cal-overlay-container")
1408+
.should("exist")
14011409
.should("not.have.class", "ui5-cal-overlay-hidden");
14021410
});
14031411
});

packages/main/cypress/support/commands/DateRangePicker.commands.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ Cypress.Commands.add("ui5DateRangePickerClickDateInCalendar", { prevSubject: tru
9090
Cypress.Commands.add("ui5DateRangePickerVerifySelectedDatesInCalendar", { prevSubject: true }, (subject: JQuery<DateRangePicker>, calendarIndex: number) => {
9191
cy.wrap(subject)
9292
.ui5DateRangePickerGetDayPicker(calendarIndex)
93+
.should("exist")
9394
.shadow()
9495
.find(".ui5-dp-item--selected")
9596
.should("exist");

0 commit comments

Comments
 (0)