Skip to content

Commit 732076b

Browse files
authored
feat(ui5-shellbar): add 8px gap between startButton elements (#13537)
When multiple buttons are slotted into startButton, there was no spacing between them. Added gap: 0.5rem to the .ui5-shellbar-start-button flex container to match the VD spec which requires 0.5rem (8px) spacing between ShellBar elements. JIRA: BGSOFUIPIRIN-7064
1 parent b51cef2 commit 732076b

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

packages/fiori/cypress/specs/ShellBar.cy.tsx

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1846,4 +1846,17 @@ describe("Component Behavior", () => {
18461846
expect(cursor).to.equal("pointer");
18471847
});
18481848
});
1849+
});
1850+
1851+
describe("Start button spacing", () => {
1852+
it("8px gap between multiple startButton elements", () => {
1853+
cy.mount(
1854+
<ShellBar>
1855+
<Button id="hamburger-btn" icon="menu2" slot="startButton"></Button>
1856+
<Button id="nav-back-btn" icon={navBack} slot="startButton"></Button>
1857+
</ShellBar>
1858+
);
1859+
1860+
cy.get("[ui5-shellbar]").shadow().find(".ui5-shellbar-start-button").should("have.css", "gap", "8px");
1861+
});
18491862
});

packages/fiori/src/themes/ShellBar.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@
126126
flex-shrink: 0;
127127
display: flex;
128128
align-items: center;
129+
gap: 0.5rem;
129130
}
130131

131132
.ui5-shellbar-branding-area {

0 commit comments

Comments
 (0)