Skip to content

Commit 96fb18c

Browse files
committed
address comments
1 parent 207be89 commit 96fb18c

2 files changed

Lines changed: 19 additions & 54 deletions

File tree

packages/main/cypress/specs/DateRangePicker.cy.tsx

Lines changed: 16 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -971,64 +971,26 @@ describe("Validation inside a form", () => {
971971
});
972972

973973
describe("DateRangePicker relative dates rejection", () => {
974-
it("typing 'today' sets error state", () => {
975-
cy.mount(<DateRangePicker></DateRangePicker>);
974+
const relativeKeywords = ["today", "tomorrow", "yesterday"];
976975

977-
cy.get("[ui5-daterange-picker]")
978-
.as("dateRangePicker")
979-
.shadow()
980-
.find("[ui5-datetime-input]")
981-
.realClick()
982-
.should("be.focused");
983-
984-
cy.realType("today");
985-
cy.realPress("Enter");
986-
987-
cy.get("@dateRangePicker")
988-
.should("have.value", "today");
989-
990-
cy.get("@dateRangePicker")
991-
.should("have.attr", "value-state", "Negative");
992-
});
976+
relativeKeywords.forEach(keyword => {
977+
it(`typing '${keyword}' sets error state`, () => {
978+
cy.mount(<DateRangePicker></DateRangePicker>);
993979

994-
it("typing 'tomorrow' sets error state", () => {
995-
cy.mount(<DateRangePicker></DateRangePicker>);
980+
cy.get("[ui5-daterange-picker]")
981+
.as("dateRangePicker")
982+
.shadow()
983+
.find("[ui5-datetime-input]")
984+
.realClick()
985+
.should("be.focused");
996986

997-
cy.get("[ui5-daterange-picker]")
998-
.as("dateRangePicker")
999-
.shadow()
1000-
.find("[ui5-datetime-input]")
1001-
.realClick()
1002-
.should("be.focused");
1003-
1004-
cy.realType("tomorrow");
1005-
cy.realPress("Enter");
987+
cy.realType(keyword);
988+
cy.realPress("Enter");
1006989

1007-
cy.get("@dateRangePicker")
1008-
.should("have.value", "tomorrow");
1009-
1010-
cy.get("@dateRangePicker")
1011-
.should("have.attr", "value-state", "Negative");
1012-
});
1013-
1014-
it("typing 'yesterday' sets error state", () => {
1015-
cy.mount(<DateRangePicker></DateRangePicker>);
1016-
1017-
cy.get("[ui5-daterange-picker]")
1018-
.as("dateRangePicker")
1019-
.shadow()
1020-
.find("[ui5-datetime-input]")
1021-
.realClick()
1022-
.should("be.focused");
1023-
1024-
cy.realType("yesterday");
1025-
cy.realPress("Enter");
1026-
1027-
cy.get("@dateRangePicker")
1028-
.should("have.value", "yesterday");
1029-
1030-
cy.get("@dateRangePicker")
1031-
.should("have.attr", "value-state", "Negative");
990+
cy.get("@dateRangePicker")
991+
.should("have.value", keyword)
992+
.should("have.attr", "value-state", "Negative");
993+
});
1032994
});
1033995

1034996
it("valid concrete date range does not set error state", () => {

packages/main/src/DateRangePicker.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ const DEFAULT_DELIMITER = "-";
4141
* The user can enter a date by:
4242
* Using the calendar that opens in a popup or typing it in directly in the input field (not available for mobile devices).
4343
* For the `ui5-daterange-picker`
44+
*
45+
* **Note:** Relative date values such as "today", "yesterday", or "tomorrow" are not supported.
46+
* Entering a relative date sets the component to an error state.
4447
* ### ES6 Module Import
4548
*
4649
* `import "@ui5/webcomponents/dist/DateRangePicker.js";`

0 commit comments

Comments
 (0)