chore: remove changes already covered by PR #13315 (ListItemBase semantic click)

Author: tsanislavgatev

packages/fiori/src/Search.ts

@@ -44,7 +44,6 @@ interface ISearchSuggestionItem extends UI5Element {
 	selected: boolean;
 	text: string;
 	items?: ISearchSuggestionItem[];
-	eventDetails: { click?: object };
 }
 
 type SearchEventDetails = {

packages/fiori/src/SearchItemShowMore.ts

@@ -2,7 +2,6 @@ import customElement from "@ui5/webcomponents-base/dist/decorators/customElement
 import property from "@ui5/webcomponents-base/dist/decorators/property.js";
 import event from "@ui5/webcomponents-base/dist/decorators/event-strict.js";
 import ListItemBase from "@ui5/webcomponents/dist/ListItemBase.js";
-import type { ListItemBaseClickEventDetail } from "@ui5/webcomponents/dist/ListItemBase.js";
 import jsxRenderer from "@ui5/webcomponents-base/dist/renderer/JsxRenderer.js";
 import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js";
 import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
@@ -12,7 +11,7 @@ import SearchItemShowMoreCss from "./generated/themes/SearchItemShowMore.css.js"
 import { SEARCH_ITEM_SHOW_MORE_COUNT, SEARCH_ITEM_SHOW_MORE_NO_COUNT } from "./generated/i18n/i18n-defaults.js";
 import { isEnter, isSpace } from "@ui5/webcomponents-base/dist/Keys.js";
 
-type ShowMoreItemClickEventDetail = ListItemBaseClickEventDetail & {
+type ShowMoreItemClickEventDetail = {
 	fromKeyboard: boolean;
 }
 
@@ -101,7 +100,7 @@ If a number is provided, it displays "Show more (N)", where N is that number.
 
 	_onclick(e: MouseEvent | KeyboardEvent, fromKeyboard = false) {
 		e.stopImmediatePropagation();
-		this.fireDecoratorEvent("click", { item: this, originalEvent: e, fromKeyboard });
+		this.fireDecoratorEvent("click", { fromKeyboard });
 	}
 
 	_onkeydown(e: KeyboardEvent) {

packages/main/src/ComboBox.ts

@@ -107,8 +107,7 @@ interface IComboBoxItem extends UI5Element {
 	selected?: boolean,
 	additionalText?: string,
 	_isVisible?: boolean,
-	items?: Array<IComboBoxItem>,
-	eventDetails: { click?: object },
+	items?: Array<IComboBoxItem>
 }
 
 type ValueStateAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;

packages/main/src/Input.ts

@@ -110,7 +110,6 @@ interface IInputSuggestionItem extends UI5Element {
 	focused: boolean;
 	additionalText?: string;
 	items?: IInputSuggestionItem[];
-	eventDetails: { click?: object };
 }
 
 interface IInputSuggestionItemSelectable extends IInputSuggestionItem {

packages/main/src/ListItemBase.ts

@@ -25,11 +25,6 @@ type ListItemBasePressEventDetail = {
 	key?: string,
 }
 
-type ListItemBaseClickEventDetail = {
-	item: ListItemBase,
-	originalEvent: Event,
-}
-
 /**
  * @class
  * A class to serve as a foundation
@@ -43,19 +38,6 @@ type ListItemBaseClickEventDetail = {
 	renderer: jsxRenderer,
 	styles: [styles, draggableElementStyles],
 })
-/**
- * Fired when the component is activated either with a mouse/tap or by using the Enter or Space key.
- *
- * **Note:** The event will not be fired if the `disabled` property is set to `true`.
- *
- * @since 2.22.0
- * @public
- * @param {ListItemBase} item The activated item.
- * @param {Event} originalEvent The original event from the user interaction.
- */
-@event("click", {
-	bubbles: true,
-})
 @event("request-tabindex-change", {
 	bubbles: true,
 })
@@ -74,7 +56,6 @@ type ListItemBaseClickEventDetail = {
 })
 class ListItemBase extends UI5Element implements ITabbable {
 	eventDetails!: {
-		"click": ListItemBaseClickEventDetail,
 		"request-tabindex-change": FocusEvent,
 		"_press": ListItemBasePressEventDetail,
 		"_focused": FocusEvent,
@@ -187,7 +168,6 @@ class ListItemBase extends UI5Element implements ITabbable {
 		if (this.getFocusDomRef()!.matches(":has(:focus-within)") || this._isDisabledInteractiveContentClicked(e)) {
 			return;
 		}
-		e.stopPropagation();
 		this.fireItemPress(e);
 	}
 
@@ -253,7 +233,6 @@ class ListItemBase extends UI5Element implements ITabbable {
 		if (isEnter(e as KeyboardEvent)) {
 			e.preventDefault();
 		}
-		this.fireDecoratorEvent("click", { item: this, originalEvent: e });
 		this.fireDecoratorEvent("_press", { item: this, selected: this.selected, key: (e as KeyboardEvent).key });
 	}
 
@@ -334,5 +313,4 @@ export default ListItemBase;
 
 export type {
 	ListItemBasePressEventDetail,
-	ListItemBaseClickEventDetail,
 };

packages/main/src/ListItemGroup.ts

@@ -83,7 +83,6 @@ type ListItemGroupMoveEventDetail = {
 
 class ListItemGroup extends UI5Element {
 	eventDetails!: {
-		"click"?: object,
 		"move-over": ListItemGroupMoveEventDetail,
 		"move": ListItemGroupMoveEventDetail,
 	}

packages/main/src/Menu.ts

@@ -60,7 +60,6 @@ interface IMenuItem extends UI5Element {
 	isMenuItem?: boolean;
 	isSeparator?: boolean;
 	isGroup?: boolean;
-	eventDetails: { click?: object };
 }
 
 type MenuItemClickEventDetail = {

packages/main/src/MultiComboBox.ts

@@ -128,7 +128,6 @@ interface IMultiComboBoxItem extends UI5Element {
 	isGroupItem?: boolean,
 	_isVisible?: boolean,
 	items?: Array<IMultiComboBoxItem>,
-	eventDetails: { click?: object },
 }
 
 type ValueStateAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;