Skip to content

Commit a933680

Browse files
committed
refactor(ui5-li): use hasConfigurableMode guard and fix _editMode JSDoc
- Replace "\_editMode" in listItem type guard with the existing hasConfigurableMode pattern for consistency with the rest of List.ts - Clarify JSDoc: F2 is handled by ListItem, F7 by the parent List
1 parent 349b591 commit a933680

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/main/src/List.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1416,7 +1416,7 @@ class List extends UI5Element {
14161416
onForwardBefore(e: CustomEvent) {
14171417
const listItem = e.target as ListItemBase;
14181418

1419-
if ("_editMode" in listItem && (listItem as ListItem)._editMode) {
1419+
if (listItem.hasConfigurableMode && (listItem as ListItem)._editMode) {
14201420
const allItems = this.getItems().filter(node => {
14211421
return "hasConfigurableMode" in node && node.hasConfigurableMode
14221422
&& (node as ListItem)._hasFocusableElements();
@@ -1447,7 +1447,7 @@ class List extends UI5Element {
14471447
onForwardAfter(e: CustomEvent) {
14481448
const listItem = e.target as ListItemBase;
14491449

1450-
if ("_editMode" in listItem && (listItem as ListItem)._editMode) {
1450+
if (listItem.hasConfigurableMode && (listItem as ListItem)._editMode) {
14511451
const allItems = this.getItems().filter(node => {
14521452
return "hasConfigurableMode" in node && node.hasConfigurableMode
14531453
&& (node as ListItem)._hasFocusableElements();

packages/main/src/ListItem.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ abstract class ListItem extends ListItemBase {
197197
* Indicates whether the list item is in edit mode.
198198
* When active, Tab cycles through internal focusable elements
199199
* instead of navigating to the next list item.
200-
* Toggled by F2 or F7.
200+
* Toggled by F2; also set by the parent List on F7.
201201
* @private
202202
*/
203203
_editMode = false;

0 commit comments

Comments
 (0)