Skip to content

Commit b035dbc

Browse files
chore(ui5-toolbar): toolbar item wrapper introduced (#12243)
* chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar-item): wrappers introduced * chore(ui5-toolbar-item): toolbar wrappers * chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar-item): item wrapers introduced * chore(ui5-toolbar-item): items wrappers introduced * chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar): item wrappers introduced * fix(ui5-shellbar): adjust sizes-parameters for shellbar * chore(ui5-toolbar): wrappers introduced * fix(ui5-toolbar): toolbar items introduced * chore(ui5-toolbar): toolbar wrappers introduced * chore(ui5-toolbar): wrappers introduced * chore(ui5-toolbar): toolbarItem wrappers * chore(ui5-toolbar): toolbar wrappers introduced * chore(ui5-toolbar): toolbar item wrapper introduced * chore(ui5-toolbar-item): wrappers introduced * Delete packages/main/test/pages/ToolbarWrappers.html * chore(ui5-toolbar): fix tests * chore(ui5-toolbar): fix click event handling in ToolbarItem * chore(ui5-toolbar): fix toolbar items * chore(ui5-toolbar): fix OTB width * fix(ui5-toolbar): enhance overflow handling and add new toolbar item examples * chore(ui5-toolbar): fix reviwe comments * chore(ui5-toolbar): fix review comments * fix(ui5-toolbar): fix tests * chore(ui5-toolbar): review comments * fix(ui5-toolbar): migrate ToolbarItem to UI5 Web Component * fix(ui5-toolbar-item): item wrapper introduced * fix(ui5-toolbar-item): general wrapper introduced * fix(ui5-toolbar-item): remove code from components that is not needed * fix(ui5-toolbar-item): code-review comments addressed * fix(ui5-toolbar-item): code-review comments addressed * fix(ui5-toolbar-item): correct code issue * fix(ui5-toolbar-item): checkForWrapper fixed * fix(ui5-toolbar-item): code reviews feedback implementation * fix(ui5-toolbar): typo in sample fixed * chore(ui5-toolbar): experimental flag added * chore(ui5-toolbar): failing tests fixed * chore(ui5-toolbar): failing tests fixed * feat(ui5-toolbar): failing tests fixed
1 parent 1d17d50 commit b035dbc

18 files changed

Lines changed: 1245 additions & 33 deletions

File tree

packages/main/cypress/specs/Toolbar.cy.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import ToolbarSelect from "../../src/ToolbarSelect.js";
44
import ToolbarSelectOption from "../../src/ToolbarSelectOption.js";
55
import ToolbarSeparator from "../../src/ToolbarSeparator.js";
66
import ToolbarSpacer from "../../src/ToolbarSpacer.js";
7-
import type ToolbarItem from "../../src/ToolbarItem.js";
7+
import ToolbarItem from "../../src/ToolbarItem.js";
88
import add from "@ui5/webcomponents-icons/dist/add.js";
99
import decline from "@ui5/webcomponents-icons/dist/decline.js";
1010
import employee from "@ui5/webcomponents-icons/dist/employee.js";
@@ -123,7 +123,7 @@ describe("Toolbar general interaction", () => {
123123
.should("exist", "hidden class attached to tb button, meaning it's not shown as expected");
124124
});
125125

126-
it("Should call event handlers on abstract item", () => {
126+
it("Should call event handlers on item", () => {
127127
cy.mount(
128128
<Toolbar>
129129
<ToolbarButton text="Button 1"></ToolbarButton>
@@ -575,6 +575,7 @@ describe("ToolbarButton", () => {
575575
cy.get("@toolbar").then($toolbar => {
576576
const toolbar = $toolbar[0] as Toolbar;
577577
const addButton = document.getElementById("add-btn") as ToolbarButton;
578+
578579
expect(toolbar.itemsToOverflow.includes(addButton)).to.be.true;
579580

580581
const initialOverflowCount = toolbar.itemsToOverflow.length;
@@ -664,3 +665,4 @@ describe("ToolbarButton", () => {
664665
.should("contain.text", "Decline Item");
665666
});
666667
});
668+

0 commit comments

Comments
 (0)