Skip to content

Commit bae9ae4

Browse files
chore: fix focus outline
1 parent 29e4dcb commit bae9ae4

8 files changed

Lines changed: 14 additions & 18 deletions

File tree

packages/main/src/themes/RadioButton.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@
5555
content: "";
5656
display: var(--_ui5_radio_button_focus_outline);
5757
position: absolute;
58-
inset: var(--_ui5_radio_button_focus_dist);
58+
inset-block: calc(-1 * var(--_ui5_radio_button_focus_dist));
59+
inset-inline: calc(-1 * var(--_ui5_radio_button_focus_dist)) var(--_ui5_radio_button_focus_dist);
5960
pointer-events: none;
6061
border: var(--_ui5_radio_button_border_width) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
6162
border-radius: var(--_ui5_radio_button_border_radius);
@@ -207,6 +208,7 @@
207208
.ui5-radio-inner {
208209
display: flex;
209210
align-items: center;
211+
align-self: start;
210212
padding-inline-end: var(--_ui5_radio_button_outer_ring_padding);
211213
flex: 1;
212214
pointer-events: none;
@@ -238,10 +240,6 @@
238240
font-size: inherit;
239241
}
240242

241-
:host([wrapping-type="None"][text]) .ui5-radio-root {
242-
height: var(--_ui5_radio_button_height);
243-
}
244-
245243
:host([wrapping-type="None"][text]) [ui5-label].ui5-radio-label {
246244
text-overflow: ellipsis;
247245
overflow: hidden;

packages/main/src/themes/base/RadioButton-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
--_ui5_radio_button_border_radius: 0;
2424
--_ui5_radio_button_border: none;
2525
--_ui5_radio_button_focus_outline: block;
26-
--_ui5_radio_button_focus_dist: 0.5rem;
26+
--_ui5_radio_button_focus_dist: 0.1375rem;
2727
--_ui5_radio_button_color: var(--sapField_BorderColor);
2828
--_ui5_radio_button_label_offset: 1px;
2929
--_ui5_radio_button_label_color: var(--sapContent_LabelColor);
@@ -38,7 +38,7 @@
3838
@container style(--ui5_content_density: compact) {
3939
:host {
4040
--_ui5_radio_button_min_width: 2rem;
41-
--_ui5_radio_button_focus_dist: 0.375rem;
41+
--_ui5_radio_button_focus_dist: 0.125rem;
4242
--_ui5_radio_button_outer_ring_padding_with_label: 0.5rem;
4343
}
4444
}

packages/main/src/themes/base/sizes-parameters.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@
122122
--_ui5_textarea_margin: .25rem 0;
123123

124124
/* Radio Button */
125-
--_ui5_radio_button_height: 2.75rem;
126125
--_ui5_radio_button_label_side_padding: .6875rem;
127126
--_ui5_radio_button_inner_size: 2.75rem;
128127
--_ui5_radio_button_svg_size: 1.5714em;
@@ -321,7 +320,6 @@
321320
--_ui5_tc_item_icon_circle_size: 2rem;
322321

323322
/* Radio Button */
324-
--_ui5_radio_button_height: 2rem;
325323
--_ui5_radio_button_label_side_padding: 0.5rem;
326324
--_ui5_radio_button_inner_size: 2rem;
327325
--_ui5_radio_button_svg_size: 1.1429em;

packages/main/src/themes/sap_horizon/RadioButton-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
--_ui5_radio_button_checked_warning_fill: var(--sapField_WarningColor);
1717
--_ui5_radio_button_read_only_inner_ring_color: var(--sapField_TextColor);
1818
--_ui5_radio_button_read_only_border_width: var(--sapElement_BorderWidth);
19-
--_ui5_radio_button_focus_dist: 0.375rem;
19+
--_ui5_radio_button_focus_dist: 0.325rem;
2020
}
2121

2222
@container style(--ui5_content_density: compact) {
2323
:host {
2424
--_ui5_radio_button_outer_ring_padding: 0.5rem;
25-
--_ui5_radio_button_focus_dist: 0.1875rem;
25+
--_ui5_radio_button_focus_dist: 0.275rem;
2626
}
2727
}

packages/main/src/themes/sap_horizon_dark/RadioButton-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
--_ui5_radio_button_checked_warning_fill: var(--sapField_WarningColor);
1717
--_ui5_radio_button_read_only_inner_ring_color: var(--sapField_TextColor);
1818
--_ui5_radio_button_read_only_border_width: var(--sapElement_BorderWidth);
19-
--_ui5_radio_button_focus_dist: 0.375rem;
19+
--_ui5_radio_button_focus_dist: 0.325rem;
2020
}
2121

2222
@container style(--ui5_content_density: compact) {
2323
:host {
2424
--_ui5_radio_button_outer_ring_padding: 0.5rem;
25-
--_ui5_radio_button_focus_dist: 0.1875rem;
25+
--_ui5_radio_button_focus_dist: 0.275rem;
2626
}
2727
}

packages/main/src/themes/sap_horizon_hcb/RadioButton-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
--_ui5_radio_button_outer_ring_padding: 0.6875rem;
1616
--_ui5_radio_button_read_only_border_width: var(--sapElement_BorderWidth);
1717
--_ui5_radio_button_read_only_inner_ring_color: var(--sapField_TextColor);
18-
--_ui5_radio_button_focus_dist: 0.375rem;
18+
--_ui5_radio_button_focus_dist: 0.325rem;
1919
}
2020

2121
@container style(--ui5_content_density: compact) {
2222
:host {
2323
--_ui5_radio_button_outer_ring_padding: 0.5rem;
24-
--_ui5_radio_button_focus_dist: 0.1875rem;
24+
--_ui5_radio_button_focus_dist: 0.275rem;
2525
}
2626
}

packages/main/src/themes/sap_horizon_hcw/RadioButton-parameters.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919
--_ui5_radio_button_outer_ring_padding: 0.6875rem;
2020
--_ui5_radio_button_read_only_border_width: var(--sapElement_BorderWidth);
2121
--_ui5_radio_button_read_only_inner_ring_color: var(--sapField_TextColor);
22-
--_ui5_radio_button_focus_dist: 0.375rem;
22+
--_ui5_radio_button_focus_dist: 0.325rem;
2323
}
2424

2525
@container style(--ui5_content_density: compact) {
2626
:host {
2727
--_ui5_radio_button_outer_ring_padding: 0.5rem;
28-
--_ui5_radio_button_focus_dist: 0.1875rem;
28+
--_ui5_radio_button_focus_dist: 0.275rem;
2929
}
3030
}

packages/main/test/pages/RadioButton.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<link rel="stylesheet" type="text/css" href="./styles/RadioButton.css">
99
</head>
1010

11-
<body class="radiobutton1auto">
11+
<body class="radiobutton1auto sapUiSizeCompact">
1212

1313
<ui5-radio-button name="simple" text="Option A"></ui5-radio-button>
1414
<ui5-radio-button checked name="simple" text="Option B"></ui5-radio-button>

0 commit comments

Comments
 (0)