Skip to content

Commit cca4ca4

Browse files
fix(ui5-*): fix event type
1 parent 78fa76b commit cca4ca4

6 files changed

Lines changed: 11 additions & 13 deletions

File tree

packages/fiori/src/Search.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,13 @@ import type Input from "@ui5/webcomponents/dist/Input.js";
3939
import type { PopupBeforeCloseEventDetail } from "@ui5/webcomponents/dist/Popup.js";
4040
import type Select from "@ui5/webcomponents/dist/Select.js";
4141
import type { Slot, DefaultSlot } from "@ui5/webcomponents-base/dist/UI5Element.js";
42+
import type { ListItemBaseClickEventDetail } from "@ui5/webcomponents/dist/ListItemBase.js";
4243

4344
interface ISearchSuggestionItem extends UI5Element {
4445
selected: boolean;
4546
text: string;
4647
items?: ISearchSuggestionItem[];
47-
eventDetails: { click?: object };
48+
eventDetails: { click?: ListItemBaseClickEventDetail };
4849
}
4950

5051
type SearchEventDetails = {

packages/main/src/ComboBox.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ import { isInstanceOfComboBoxItemGroup } from "./ComboBoxItemGroup.js";
9090
import type ComboBoxFilter from "./types/ComboBoxFilter.js";
9191
import type Input from "./Input.js";
9292
import type { InputEventDetail } from "./Input.js";
93+
import type { ListItemBaseClickEventDetail } from "./ListItemBase.js";
9394
import type InputComposition from "./features/InputComposition.js";
9495

9596
const SKIP_ITEMS_SIZE = 10;
@@ -108,8 +109,7 @@ interface IComboBoxItem extends UI5Element {
108109
additionalText?: string,
109110
_isVisible?: boolean,
110111
items?: Array<IComboBoxItem>,
111-
eventDetails: { click?: object },
112-
}
112+
eventDetails: { click?: ListItemBaseClickEventDetail },
113113

114114
type ValueStateAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;
115115
type ValueStateTypeAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;

packages/main/src/Input.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ import ResponsivePopoverCommonCss from "./generated/themes/ResponsivePopoverComm
9797
import ValueStateMessageCss from "./generated/themes/ValueStateMessage.css.js";
9898
import SuggestionsCss from "./generated/themes/Suggestions.css.js";
9999
import type { ListItemClickEventDetail, ListSelectionChangeEventDetail } from "./List.js";
100+
import type { ListItemBaseClickEventDetail } from "./ListItemBase.js";
100101
import type ResponsivePopover from "./ResponsivePopover.js";
101102
import type InputKeyHint from "./types/InputKeyHint.js";
102103
import type InputComposition from "./features/InputComposition.js";
@@ -110,8 +111,7 @@ interface IInputSuggestionItem extends UI5Element {
110111
focused: boolean;
111112
additionalText?: string;
112113
items?: IInputSuggestionItem[];
113-
eventDetails: { click?: object };
114-
}
114+
eventDetails: { click?: ListItemBaseClickEventDetail };
115115

116116
interface IInputSuggestionItemSelectable extends IInputSuggestionItem {
117117
text?: string;

packages/main/src/Menu.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
22
import type { DefaultSlot } from "@ui5/webcomponents-base/dist/UI5Element.js";
3+
import type { ListItemBaseClickEventDetail } from "./ListItemBase.js";
34
import customElement from "@ui5/webcomponents-base/dist/decorators/customElement.js";
45
import property from "@ui5/webcomponents-base/dist/decorators/property.js";
56
import slot from "@ui5/webcomponents-base/dist/decorators/slot-strict.js";
@@ -60,10 +61,7 @@ interface IMenuItem extends UI5Element {
6061
isMenuItem?: boolean;
6162
isSeparator?: boolean;
6263
isGroup?: boolean;
63-
eventDetails: { click?: object };
64-
}
65-
66-
type MenuItemClickEventDetail = {
64+
eventDetails: { click?: ListItemBaseClickEventDetail };
6765
item: MenuItem,
6866
text: string,
6967
}

packages/main/src/MultiComboBox.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ interface IMultiComboBoxItem extends UI5Element {
128128
isGroupItem?: boolean,
129129
_isVisible?: boolean,
130130
items?: Array<IMultiComboBoxItem>,
131-
eventDetails: { click?: object },
132-
}
131+
eventDetails: { click?: ListItemBaseClickEventDetail },
133132

134133
type ValueStateAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;
135134
type ValueStateTypeAnnouncement = Record<Exclude<ValueState, ValueState.None>, string>;

packages/main/src/TabContainer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import type Button from "./Button.js";
4747
import type List from "./List.js";
4848
import type DropIndicator from "./DropIndicator.js";
4949
import type Tab from "./Tab.js";
50-
import type { TabInStrip, TabInOverflow } from "./Tab.js";
50+
import type { TabInStrip, TabInOverflow, TabClickEventDetail } from "./Tab.js";
5151
import type { TabSeparatorInStrip } from "./TabSeparator.js";
5252
import type { ListItemClickEventDetail, ListMoveEventDetail } from "./List.js";
5353
import type ResponsivePopover from "./ResponsivePopover.js";
@@ -111,7 +111,7 @@ interface ITab extends UI5Element {
111111
receiveOverflowInfo: (arg0: TabContainerOverflowInfo) => void;
112112
getDomRefInStrip: () => HTMLElement | undefined;
113113
items?: Array<ITab>;
114-
eventDetails: { click?: object };
114+
eventDetails: { click?: TabClickEventDetail };
115115
}
116116

117117
/**

0 commit comments

Comments
 (0)