Skip to content

Commit df94092

Browse files
committed
fix: address comments
1 parent 10e6682 commit df94092

4 files changed

Lines changed: 4 additions & 1 deletion

File tree

packages/main/src/Select.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,6 +1105,7 @@ class Select extends UI5Element implements IFormInputElement {
11051105
},
11061106
responsivePopover: {
11071107
"min-width": `${this.offsetWidth}px`,
1108+
"margin-top": "var(--sapField_BorderWidth)",
11081109
},
11091110
};
11101111
}

packages/main/src/themes/base/Select-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
--_ui5_select_icon_width: 2.25rem;
55
--_ui5_select_icon_wrapper_height: 100%;
66
--_ui5_select_bottom_border_gradient: none;
7-
--_ui5_select_icon_wrapper_state_height: calc(100% - 0.125rem);
7+
--_ui5_select_icon_wrapper_state_height: 100%;
88
}
99

1010
@container style(--ui5_content_density: compact) {

packages/main/src/themes/sap_horizon/Select-parameters.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
--_ui5_select_icon_wrapper_height: 100%;
66
--_ui5_select_icon_wrapper_state_height: 100%;
77
--_ui5_input_icon_hover_bg: transparent;
8+
--_ui5_input_icon_pressed_bg: transparent;
89
--_ui5_select_bottom_border_gradient: linear-gradient(var(--sapField_BorderColor), var(--sapField_BorderColor)) bottom / 100% var(--sapField_BorderWidth) no-repeat;
910
--_ui5_input_focus_outline_color: var(--sapContent_FocusColor);
1011
--_ui5_input_readonly_focus_border_radius: 0;

packages/main/src/themes/sap_horizon_dark/Select-parameters.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
--_ui5_select_icon_wrapper_height: 100%;
66
--_ui5_select_icon_wrapper_state_height: 100%;
77
--_ui5_input_icon_hover_bg: transparent;
8+
--_ui5_input_icon_pressed_bg: transparent;
89
--_ui5_select_bottom_border_gradient: linear-gradient(var(--sapField_BorderColor), var(--sapField_BorderColor)) bottom / 100% var(--sapField_BorderWidth) no-repeat;
910
--_ui5_input_focus_outline_color: var(--sapContent_FocusColor);
1011
--_ui5_input_readonly_focus_border_radius: 0;

0 commit comments

Comments
 (0)