refactor(ui5-range-slider): refactor ui5-range-slider component

apply code review feedback

Author: ndeshev

packages/main/src/SliderHandle.ts

@@ -75,6 +75,8 @@ class SliderHandle extends UI5Element {
 	 * <br><br>
 	 * <b>Note:</b> An active slider handle is currently being interacted with.
 	 * @since 2.22.0
+	 *
+	 * @private
 	 */
 	@property({ type: Boolean })
 	active = false;
@@ -84,6 +86,8 @@ class SliderHandle extends UI5Element {
 	 * <br><br>
 	 * <b>Note:</b> Used when the progress bar is hovered to show both handles as hovered.
 	 * @since 2.22.0
+	 *
+	 * @private
 	 */
 	@property({ type: Boolean })
 	hovered = false;

packages/main/src/SliderScaleTemplate.tsx

@@ -36,9 +36,9 @@ export default function SliderScaleTemplate(this: SliderScale) {
 				style={this._progressStyle}
 				tabIndex={this.progressTabIndex}
 				role="slider"
-				aria-orientation={this.progressRole ? "horizontal" : undefined}
-				aria-valuemin={this.progressRole ? this.min : undefined}
-				aria-valuemax={this.progressRole ? this.max : undefined}
+				aria-orientation="horizontal"
+				aria-valuemin={this.min}
+				aria-valuemax={this.max}
 				aria-valuenow={this.progressAriaValueNow}
 				aria-valuetext={this.progressAriaValueText}
 				aria-label={this.progressAriaLabel}

packages/main/src/themes/SliderTooltip.css

@@ -12,7 +12,7 @@
 	padding: 0 0.5rem;
 	font-family: var(--sapFontFamily);
 	font-size: var(--sapFontSmallSize);
-	color: var(--sapContent_LabelColor);
+	color: var(--_ui5_slider_tooltip_color);
 	display: flex;
 	justify-content: center;
 	align-items: center;

packages/main/src/themes/base/SliderTooltip-parameters.css

@@ -0,0 +1,3 @@
+:host {
+	--_ui5_slider_tooltip_color: var(--sapTextColor);
+}

packages/main/src/themes/sap_fiori_3/SliderTooltip-parameters.css

@@ -0,0 +1,5 @@
+@import "../base/SliderTooltip-parameters.css";
+
+:host {
+	--_ui5_slider_tooltip_color: var(--sapContent_LabelColor);
+}

packages/main/src/themes/sap_fiori_3_dark/SliderTooltip-parameters.css

@@ -0,0 +1,5 @@
+@import "../base/SliderTooltip-parameters.css";
+
+:host {
+	--_ui5_slider_tooltip_color: var(--sapContent_LabelColor);
+}

packages/main/src/themes/sap_fiori_3_hcb/SliderTooltip-parameters.css

@@ -0,0 +1,5 @@
+@import "../base/SliderTooltip-parameters.css";
+
+:host {
+	--_ui5_slider_tooltip_color: var(--sapContent_LabelColor);
+}

packages/main/src/themes/sap_fiori_3_hcw/SliderTooltip-parameters.css

@@ -0,0 +1,5 @@
+@import "../base/SliderTooltip-parameters.css";
+
+:host {
+	--_ui5_slider_tooltip_color: var(--sapContent_LabelColor);
+}

packages/main/src/themes/sap_horizon_dark/SliderTooltip-parameters.css

@@ -0,0 +1 @@
+@import "../base/SliderTooltip-parameters.css";

packages/main/src/themes/sap_horizon_hcb/SliderHandle-parameters.css

@@ -1,7 +1,6 @@
 @import "../sap_horizon/SliderHandle-parameters.css";
 
 :host {
-	--_ui5_range_slider_root_hover_handle_bg: var(--sapButton_Hover_Background);
 	--ui5_slider_handle_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
 	--ui5_slider_handle_outline_offset: 0.0625rem;
 }