Skip to content

Commit f0c277e

Browse files
authored
feat(ui5-shellbar): align padding and logo styles with VD spec (#13535)
Aligns ShellBarBranding.css with the Shell Bar (Horizon) Visual Design specification. Changes: - Container height: added explicit height: 2.25rem (36px) to .ui5-shellbar-branding-root to cap the branding area at the correct size - Container padding-block: reduced from 0.25rem (4px) to 0.125rem (2px) top and bottom, as specified - Container padding-inline: kept at 0.25rem left / 0.5rem right (4px / 8px) — already correct - Standalone logo right spacing: reduced .ui5-shellbar-logo-area right padding from 0.5rem to 0.25rem to avoid the double 8px gap that was appearing when no product identifier is present - Slotted logo max-height: reduced from 2rem (32px) to 1.875rem (30px) with 1px top/bottom padding-block breathing space, so the logo renders at the correct 30px height without being clipped - Slotted logo width: added width: auto to ensure proportional scaling regardless of the logo's original dimensions Spec reference Shell Bar (Horizon) — Branding section: - Branding container: height 2.25rem, padding top/bottom 2px, padding left 0.25rem (4px), padding right 0.5rem (8px) - Logo: max-height 2rem, 1px top/bottom breathing space, padding left/right 0.25rem (4px) - Spacing between logo and product identifier: 0.25rem (4px) JIRA: BGSOFUIPIRIN-7065
1 parent 14c4218 commit f0c277e

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

packages/fiori/src/themes/ShellBarBranding.css

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
overflow: hidden;
1111
display: flex;
1212
align-items: center;
13-
padding-block: 0.25rem;
13+
height: 2.25rem;
14+
padding-block: 0.125rem;
1415
padding-inline: 0.25rem 0.5rem;
1516
box-sizing: border-box;
1617
cursor: pointer;
@@ -19,7 +20,7 @@
1920
color: var(--sapShell_TextColor);
2021
/* fix cutting of the focus outline */
2122
margin-inline-start: 0.125rem;
22-
margin-inline-end: .5rem;
23+
margin-inline-end: 0.5rem;
2324
}
2425

2526
.ui5-shellbar-branding-root:focus {
@@ -55,7 +56,7 @@
5556
overflow: hidden;
5657
display: flex;
5758
align-items: center;
58-
padding: .25rem .5rem .25rem .25rem;
59+
padding: 0.125rem 0.25rem 0.125rem 0.25rem;
5960
box-sizing: border-box;
6061
cursor: pointer;
6162
background: var(--sapButton_Lite_Background);
@@ -66,7 +67,9 @@
6667
}
6768

6869
::slotted([slot="logo"]) {
69-
max-height: 2rem;
70+
max-height: 1.875rem;
71+
width: auto;
72+
padding-block: 0.0625rem;
7073
padding-inline: 0.25rem;
7174
vertical-align: middle;
7275
}

0 commit comments

Comments
 (0)