Skip to content

Commit f7792c2

Browse files
fix(ui5-slider/ui5-range-slider): implement vd spec
1 parent f617c9d commit f7792c2

4 files changed

Lines changed: 11 additions & 6 deletions

File tree

packages/main/src/themes/SliderBase.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
height: var(--_ui5_slider_progress_height);
7373
position: relative;
7474
outline: none;
75-
box-sizing: border-box;
75+
box-sizing: var(--_ui5_slider_active_progress_box_sizing);
7676
border: var(--_ui5_slider_active_progress_border);
7777
left: var(--_ui5_slider_active_progress_left);
7878
top: var(--_ui5_slider_active_progress_top);
@@ -84,7 +84,7 @@
8484
margin: 0;
8585
top: var(--_ui5_slider_tickmark_top);
8686
display: flex;
87-
box-sizing: content-box;
87+
box-sizing: border-box;
8888
width: 100%;
8989
justify-content: space-between;
9090
position: absolute;

packages/main/src/themes/base/SliderBase-parameters.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
--_ui5_slider_tickmark_height: 1rem;
6565
--_ui5_slider_tickmark_top: -.3125rem;
6666
--_ui5_slider_progress_box_sizing: border-box;
67+
--_ui5_slider_active_progress_box_sizing: content-box;
6768
--_ui5_slider_tickmark_in_range_bg: var(--sapField_BorderColor);
6869
--_ui5_range_slider_focus_outline_width: 100%;
6970
--_ui5_slider_progress_outline_offset_left: 0;

packages/main/src/themes/sap_horizon_hcb/SliderBase-parameters.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
--_ui5_range_slider_handle_background: var(--sapSlider_RangeHandleBackground);
1919
--_ui5_range_slider_root_hover_handle_bg: var(--sapButton_Hover_Background);
2020
--_ui5_range_slider_handle_active_background: var(--sapSlider_Active_RangeHandleBackground);
21-
--_ui5_slider_inner_height: 0.375rem;
21+
--_ui5_slider_inner_height: 0.25rem;
2222
--_ui5_slider_progress_border_radius: 0.25rem;
2323
--_ui5_slider_progress_background: var(--sapSlider_Selected_Background);
2424
--_ui5_slider_progress_container_background: var(--sapSlider_Background);
@@ -37,10 +37,12 @@
3737
--_ui5_slider_tickmark_height: .5rem;
3838
--_ui5_slider_tickmark_top: -.125rem;
3939
--_ui5_slider_progress_box_sizing: border-box;
40+
--_ui5_slider_active_progress_box_sizing: border-box;
4041

4142
--_ui5_slider_progress_container_top: .0625rem;
42-
--_ui5_slider_progress_height: .25rem;
43+
--_ui5_slider_progress_height: .375rem;
4344
--_ui5_slider_active_progress_left: -.0625rem;
45+
--_ui5_slider_active_progress_top: -.15625rem;
4446

4547
--_ui5_slider_no_tickmarks_progress_container_top: 0;
4648
--_ui5_slider_no_tickmarks_progress_height: 100%;

packages/main/src/themes/sap_horizon_hcw/SliderBase-parameters.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
--_ui5_range_slider_handle_background: var(--sapSlider_RangeHandleBackground);
1919
--_ui5_range_slider_root_hover_handle_bg: var(--sapButton_Hover_Background);
2020
--_ui5_range_slider_handle_active_background: var(--sapSlider_Active_RangeHandleBackground);
21-
--_ui5_slider_inner_height: 0.375rem;
21+
--_ui5_slider_inner_height: 0.25rem;
2222
--_ui5_slider_progress_border_radius: 0.25rem;
2323
--_ui5_slider_progress_background: var(--sapSlider_Selected_Background);
2424
--_ui5_slider_progress_container_background: var(--sapSlider_Background);
@@ -37,10 +37,12 @@
3737
--_ui5_slider_tickmark_height: .5rem;
3838
--_ui5_slider_tickmark_top: -.125rem;
3939
--_ui5_slider_progress_box_sizing: border-box;
40+
--_ui5_slider_active_progress_box_sizing: border-box;
4041

4142
--_ui5_slider_progress_container_top: .0625rem;
42-
--_ui5_slider_progress_height: .25rem;
43+
--_ui5_slider_progress_height: .375rem;
4344
--_ui5_slider_active_progress_left: -.0625rem;
45+
--_ui5_slider_active_progress_top: -.15625rem;
4446

4547
--_ui5_slider_no_tickmarks_progress_container_top: 0;
4648
--_ui5_slider_no_tickmarks_progress_height: 100%;

0 commit comments

Comments
 (0)