fix(framework): prevent language-aware components from rendering before CLDR data loads#13602
Merged
Conversation
…re CLDR data loads
nnaydenow
requested review from
ilhan007 and
pskelin
and removed request for
pskelin
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13602--ui5-webcomponents.netlify.app |
pskelin
previously approved these changes
May 28, 2026
pskelin
approved these changes
May 28, 2026
|
🎉 This PR is included in version v2.23.0-rc.2 🎉 The release is available on v2.23.0-rc.2 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
setLanguage()is called without awaiting,languageChangePendingis set to true while CLDR/i18n data is still being fetched. Previously, a language-aware component mounted during this window would callrenderImmediatelywith incomplete locale data, causing a crash.The fix registers the element in
connectedCallbackbefore any async work, then bails out of rendering if a language change is pending. Once CLDR resolves,reRenderAllUI5Elements({ languageAware: true })picks up the registered element and renders it correctly.registerElement/unregisterElementare extracted fromrenderImmediatelyandcancelRenderand exported soUI5Elementcan call them independently of the render cycle.