Skip to content

chore(ui5-toolbar): toolbar item wrapper introduced#12243

Merged
PetyaMarkovaBogdanova merged 75 commits intomainfrom
poc-toolbar-item
Feb 10, 2026
Merged

chore(ui5-toolbar): toolbar item wrapper introduced#12243
PetyaMarkovaBogdanova merged 75 commits intomainfrom
poc-toolbar-item

Conversation

@PetyaMarkovaBogdanova
Copy link
Copy Markdown
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented Sep 2, 2025

feat(ui5-toolbar-item): Refactor to a physical item for enhanced overflow logic

The ui5-toolbar-item has been refactored from an abstract item to a physical item, enabling the transfer of logic for overflowPriority and preventOverflowClosing directly to it.

Key Enhancements:

  • Universal Wrapping: The ui5-toolbar-item can now wrap all types of components, allowing them to participate in the overflow toolbar logic seamlessly.
  • Pre-defined Wrappers: For certain components, pre-defined wrappers are available. A console warning is displayed to encourage their use when applicable.
  • 100% Expansion in Overflow: Components that need to expand fully in the overflow popover can now implement the expandInOverflow property.
  • Self Overflow Logic: Components with internal overflow logic can implement the selfOverflowed property.

This enhancement improves flexibility and ensures better integration of components within the overflow toolbar logic.

Comment thread packages/main/src/ToolbarItem.ts
Comment thread packages/main/src/ToolbarItem.ts Outdated
Comment thread packages/main/src/ToolbarItem.ts Outdated
Comment thread packages/main/src/ToolbarItem.ts Outdated
Comment thread packages/main/src/ToolbarItemTemplate.tsx Outdated
Comment thread packages/main/test/pages/ToolbarWrappers.html Outdated
@github-actions github-actions Bot added the Stale label Oct 8, 2025
@github-actions github-actions Bot removed the Stale label Oct 10, 2025
@github-actions github-actions Bot added the Stale label Oct 31, 2025
@github-actions github-actions Bot closed this Nov 7, 2025
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented Nov 10, 2025

🧹 Preview deployment cleaned up: https://pr-12243--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 10:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 10:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 19, 2026 08:34 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 19, 2026 08:41 Inactive
Copy link
Copy Markdown
Contributor

@dobrinyonkov dobrinyonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment - the new component ToolbarItem does not appear in the website playground. Perhaps it needs a directory in the website package. We should then check if all APIs are correctly documented.

Comment thread packages/main/src/ToolbarItem.ts Outdated
Comment thread packages/main/src/ToolbarItem.ts Outdated
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 30, 2026 11:32 Inactive
Comment thread packages/website/docs/_samples/main/Toolbar/ToolbarItem/sample.html Outdated
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 3, 2026 09:48 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 3, 2026 09:57 Inactive
Comment thread packages/main/src/ToolbarItem.ts Outdated
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 9, 2026 10:12 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 9, 2026 12:58 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 9, 2026 13:11 Inactive
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova merged commit b035dbc into main Feb 10, 2026
14 checks passed
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova deleted the poc-toolbar-item branch February 10, 2026 09:29
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview February 10, 2026 09:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants