Skip to content

fix(ui5-step-input): prevent false validation error with valuePrecision #12778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hinzzx merged 2 commits into from
Dec 10, 2025
Merged

fix(ui5-step-input): prevent false validation error with valuePrecision #12778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
411583c
fix(ui5-step-input): prevent false validation error with valuePrecision
hinzzx Dec 8, 2025
517be44
test commit
hinzzx Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/main/src/StepInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,13 @@ class StepInput extends UI5Element implements IFormInputElement {
}

get _isValueWithCorrectPrecision() {
// check if the value will be displayed with correct precision
// _displayValue has special formatting logic
if ((this.value === 0) || (Number.isInteger(this.value))) {
// integers and zero will be formatted with toFixed, so they're always valid
return true;
}

// gets either "." or "," as delimiter which is based on locale, and splits the number by it
const delimiter = this.input?.value?.includes(".") ? "." : ",";
const numberParts = this.input?.value?.split(delimiter);
Expand Down
Loading