Skip to content

refactor(ui5-file-uploader): remove form element and cleanup#12789

Merged
nnaydenow merged 1 commit into
mainfrom
fp-clean
Dec 11, 2025
Merged

refactor(ui5-file-uploader): remove form element and cleanup#12789
nnaydenow merged 1 commit into
mainfrom
fp-clean

Conversation

@nnaydenow
Copy link
Copy Markdown
Contributor

  • File input can reset by assigning new DataTransfer().files directly, so there's no need to create an extra <form> element.
  • An empty file input already returns null, so you don't need to create a temporary input element just to retrieve its default value.

@nnaydenow nnaydenow requested a review from unazko December 11, 2025 08:20
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented Dec 11, 2025

🧹 Preview deployment cleaned up: https://pr-12789--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 11, 2025 08:26 Inactive
Copy link
Copy Markdown
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as before.

@nnaydenow nnaydenow merged commit 7d5f748 into main Dec 11, 2025
21 of 22 checks passed
@nnaydenow nnaydenow deleted the fp-clean branch December 11, 2025 13:54
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 11, 2025 13:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants