Skip to content

fix(ui5-toolbar-select): sync programmatic selection#12790

Merged
NakataCode merged 2 commits into
mainfrom
toolbar-select-programmatic-changes
Dec 15, 2025
Merged

fix(ui5-toolbar-select): sync programmatic selection#12790
NakataCode merged 2 commits into
mainfrom
toolbar-select-programmatic-changes

Conversation

@NakataCode
Copy link
Copy Markdown
Contributor

@NakataCode NakataCode commented Dec 11, 2025

Programmatic changes to ToolbarSelectOption.selected property now properly synchronize with the internal Select component and maintain single selection.

  • Add custom property setter for ToolbarSelectOption.selected
  • Ensure sibling options are deselected when one is programmatically selected
  • Sync selection state to internal Select component value
  • Modify _syncOptions to use property setter for unified selection handling
  • Maintain backward compatibility for mouse-based selection
  • Add cypress test

Fixes: #12619

@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented Dec 11, 2025

🧹 Preview deployment cleaned up: https://pr-12790--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 11, 2025 11:36 Inactive
@NakataCode NakataCode marked this pull request as ready for review December 11, 2025 11:36
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 12, 2025 10:56 Inactive
@NakataCode NakataCode merged commit fc063f0 into main Dec 15, 2025
14 checks passed
@NakataCode NakataCode deleted the toolbar-select-programmatic-changes branch December 15, 2025 09:28
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 15, 2025 09:28 Inactive
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version v2.18.0-rc.1 🎉

The release is available on v2.18.0-rc.1

Your semantic-release bot 📦🚀

@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version v2.18.0 🎉

The release is available on v2.18.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ToolbarSelect]: ToolbarSelect display value does not display selected option

3 participants