feat(ui5-table-cell): merged property added#13297
Merged
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13297--ui5-webcomponents.netlify.app |
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
0788571 to
3850936
Compare
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
2 times, most recently
from
f65230c to
3d669be
Compare
1 task
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
3d669be to
0b5001e
Compare
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
0b5001e to
04a8a2a
Compare
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
04a8a2a to
50ee986
Compare
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
50ee986 to
11d6ff6
Compare
simlin
reviewed
Mar 30, 2026
- New merged boolean property on ui5-table-cell - Row borders refactored: border-top per cell instead of border-bottom per row - First row top border / last row bottom border handled via :first-of-type / :last-of-type - Selection highlight uses box-shadow instead of border-bottom to avoid layout shifts - Table now uses inset-inline-end/start, the old left/right + :dir(rtl) removed - When merged, cell's top border becomes transparent and content is hidden - Merging is disabled on hover/focus, content reveals with an opacity transition - Merging is also disabled when the row enters popin mode - Implemented via CSS Space Toggle trick, no JS needed - When a selection column is present, its border also syncs with the first merged cell - New TableCell website sample added for merged cells - Partially fixes #7238 - CPOUIFTEAMB-2624
- New merged boolean property on ui5-table-cell - Row borders refactored: border-top per cell instead of border-bottom per row - First row top border / last row bottom border handled via :first-of-type / :last-of-type - Selection highlight uses box-shadow instead of border-bottom to avoid layout shifts - Table now uses inset-inline-end/start, the old left/right + :dir(rtl) removed - When merged, cell's top border becomes transparent and content is hidden - Merging is disabled on hover/focus, content reveals with an opacity transition - Merging is also disabled when the row enters popin mode - Implemented via CSS Space Toggle trick, no JS needed - When a selection column is present, its border syncs with the first merged cell - New TableCell website sample added for merged cells - Partially fixes #7238 - CPOUIFTEAMB-2624
- New merged boolean property on ui5-table-cell - Row borders refactored: border-top per cell instead of border-bottom per row - First row top border / last row bottom border handled via :first-of-type / :last-of-type - Selection highlight uses box-shadow instead of border-bottom to avoid layout shifts - Table now uses inset-inline-end/start, the old left/right + :dir(rtl) removed - When merged, cell's top border becomes transparent and content is hidden - Merging is disabled on hover/focus, content reveals with an opacity transition - Merging is also disabled when the row enters popin mode - Implemented via CSS Space Toggle trick, no JS needed - When a selection column is present, its border syncs with the first merged cell - New TableCell website sample added for merged cells - Partially fixes #7238 - CPOUIFTEAMB-2624
aborjinik
force-pushed
the
table-vertical-cell-merging
branch
from
11d6ff6 to
b6ccc1f
Compare
simlin
approved these changes
Mar 30, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
KvM2
reviewed
Mar 31, 2026
Contributor
KvM2
left a comment
KvM2
left a comment
There was a problem hiding this comment.
Good texts, just a few minor things that keep reappearing.
Contributor
Author
|
@KvM2 Thank you! I will take care of them in a separate change and let you know |
Collaborator
|
🎉 This PR is included in version v2.21.0-rc.4 🎉 The release is available on v2.21.0-rc.4 Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version v2.21.0 🎉 The release is available on v2.21.0 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
mergedboolean property onui5-table-cellRow borders refactored: border-top per cell instead of border-bottom per row
First row top border / last row bottom border handled via :first-of-type / :last-of-type
Selection highlight uses box-shadow instead of border-bottom to avoid layout shifts
Table now uses inset-inline-end/start, the old left/right + :dir(rtl) removed
When merged, cell's top border becomes transparent and content is hidden
Merging is disabled on hover/focus, content reveals with an opacity transition but border stays transparent
Merging is also disabled when the row enters popin mode
Implemented via CSS Space Toggle trick, no JS needed
When a selection column is present, its border also syncs with the first merged cell
New TableCell website sample added for merged cells
Partially fixes [Feature Request]:
<ui5-table-cell>should supportcolspan#7238Also fixes [TableSelectionMulti]: Compact does not apply to checkboxes #13299
CPOUIFTEAMB-2624
CPOUIFTEAMB-2449
CPOUIFTEAMB-1348