Skip to content

fix(ui5-carousel): prevent negative values in visibleItemsIndices #13370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duygu-rmdn wants to merge 2 commits into from
Closed

fix(ui5-carousel): prevent negative values in visibleItemsIndices #13370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20026b
Revert "fix(ui5-busy-indicator): add correct color for HCB and HCW th…
duygu-rmdn Mar 9, 2026
07a936a
fix(ui5-carousel): prevent negative values in visibleItemsIndices
duygu-rmdn Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/main/cypress/specs/Carousel.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,4 +777,26 @@ describe("Carousel general interaction", () => {

cy.get("#outsideButton").should("be.focused");
});

it("visibleItemsIndices should not contain negative values when initial items < itemsPerPage", () => {
cy.mount(
<Carousel id="dynamicCarousel" itemsPerPage="S1 M2 L3 XL4">
<Card>Card 1</Card>
<Card>Card 2</Card>
</Carousel>
);

cy.viewport(1200, 500);

cy.get("#dynamicCarousel")
.shadow()
.find(".ui5-carousel-item:not(.ui5-carousel-item--hidden)")
.should("have.length", 2);

cy.get<Carousel>("#dynamicCarousel")
.then($carousel => {
const indices = $carousel[0].visibleItemsIndices;
expect(indices.every(i => i >= 0), "visibleItemsIndices should not contain negative values").to.be.true;
});
});
});
2 changes: 1 addition & 1 deletion packages/main/src/Carousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ class Carousel extends UI5Element {
}

if (newItemIndex > items.length - effectiveItemsPerPage) {
newItemIndex = items.length - effectiveItemsPerPage;
newItemIndex = Math.max(0, items.length - effectiveItemsPerPage);
}
const lastItemIndex = newItemIndex + effectiveItemsPerPage;

Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_hcb/BusyIndicator-parameters.css
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/main/src/themes/sap_fiori_3_hcb/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
@import "../base/Breadcrumbs-parameters.css";
@import "./Button-parameters.css";
@import "../base/ButtonBadge-parameters.css";
@import "./BusyIndicator-parameters.css";
@import "../base/CalendarLegend-parameters.css";
@import "../base/CalendarLegendItem-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
5 changes: 0 additions & 5 deletions packages/main/src/themes/sap_fiori_3_hcw/BusyIndicator-parameters.css
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/main/src/themes/sap_fiori_3_hcw/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
@import "../base/Breadcrumbs-parameters.css";
@import "./Button-parameters.css";
@import "../base/ButtonBadge-parameters.css";
@import "./BusyIndicator-parameters.css";
@import "../base/CalendarLegend-parameters.css";
@import "../base/CalendarLegendItem-parameters.css";
@import "./CalendarHeader-parameters.css";
Expand Down
Loading