feat(ui5-user-menu-item) - add optional second line#13397
Open
SvilenDarvenyashki wants to merge 7 commits intomainfrom
Open
feat(ui5-user-menu-item) - add optional second line#13397SvilenDarvenyashki wants to merge 7 commits intomainfrom
SvilenDarvenyashki wants to merge 7 commits intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13397--ui5-webcomponents-preview.netlify.app |
SvilenDarvenyashki
changed the title
Okiana
approved these changes
Apr 28, 2026
…ests - Fix ESLint func-names/space-before-function-paren in MenuItemTemplate - Update UserMenuItem CSS: 3.25rem height for two-line selection display, 0.5rem padding, 0.25rem gap, proper font styling with SAP theme vars - Fix CSS selector from [show-selection-text] to [show-selection] - Add 17 Cypress tests for showSelection, single-select behavior, UserMenuItemGroup, CSS styling, and nested submenu items
Single-select unchecking is now only blocked when the parent item has showSelection set, so regular single-select groups remain uncheckable as expected.
SvilenDarvenyashki
force-pushed
the
user-menu-item
branch
from
f792ca0 to
eb7cf4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
showSelectionproperty onui5-user-menu-itemthat rendersa second text line below the menu item, displaying the currently checked
sub-item's text. This enables users to see the active selection (e.g.
current theme, language) without opening the submenu.