WIP(ui5-view-settings-dialog): add announcements on OK/Cancel press#13415
Draft
NHristov-sap wants to merge 1 commit intomainfrom
Draft
WIP(ui5-view-settings-dialog): add announcements on OK/Cancel press#13415NHristov-sap wants to merge 1 commit intomainfrom
NHristov-sap wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13415--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ui5-view-settings-dialogthere is already announcement for resetting the state (pressing Reset button)to the initial one, but for closing with OK or Cancel buttons there is nothing announced. There should be announcement in both cases, because visual impaired user might not understand what happens on closing of the ViewSettingsDialog - when the OK button is pressed, there are changes in the settings that VSD contains, and this should be clear to the user; when the Cancel button is pressed, all changes made since the last VSD opening are abandoned, and this also should be announced clearly, so the user to be aware of what is happening.