Skip to content

WIP(ui5-view-settings-dialog): add announcements on OK/Cancel press #13415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NHristov-sap wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Draft

WIP(ui5-view-settings-dialog): add announcements on OK/Cancel press #13415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/fiori/src/ViewSettingsDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ import {
VSD_FILTER_TOOLTIP,
VSD_GROUP_TOOLTIP,
VSD_RESET_BUTTON_ACTION,
VSD_CONFIRM_BUTTON_ACTION,
VSD_CANCEL_BUTTON_ACTION,
VSD_FILTER_ITEM_LABEL_TEXT,
} from "./generated/i18n/i18n-defaults.js";

Expand Down Expand Up @@ -556,6 +558,14 @@ class ViewSettingsDialog extends UI5Element {
return ViewSettingsDialog.i18nBundle.getText(VSD_RESET_BUTTON_ACTION);
}

get _confirmButtonAction() {
return ViewSettingsDialog.i18nBundle.getText(VSD_CONFIRM_BUTTON_ACTION);
}

get _cancelButtonAction() {
return ViewSettingsDialog.i18nBundle.getText(VSD_CANCEL_BUTTON_ACTION);
}

get _isPhone() {
return isPhone();
}
Expand Down Expand Up @@ -819,6 +829,7 @@ class ViewSettingsDialog extends UI5Element {
this.open = false;
this._confirmedSettings = this._currentSettings;

announce(this._confirmButtonAction, InvisibleMessageMode.Assertive);
this.fireDecoratorEvent("confirm", this.eventsParams);
}

Expand All @@ -828,6 +839,7 @@ class ViewSettingsDialog extends UI5Element {
_cancelSettings() {
this._restoreSettings(this._confirmedSettings);

announce(this._cancelButtonAction, InvisibleMessageMode.Assertive);
this.fireDecoratorEvent("cancel", this.eventsParams);
this.open = false;
}
Expand Down
6 changes: 6 additions & 0 deletions packages/fiori/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ VSD_RESET_BUTTON=Reset
#XMSG: View Settings Dialog Reset button invisible message text
VSD_RESET_BUTTON_ACTION=Reset has reverted all settings to initial state

#XMSG: View Settings Dialog Confirm button invisible message text
VSD_CONFIRM_BUTTON_ACTION=Settings have been confirmed

#XMSG: View Settings Dialog Cancel button invisible message text
VSD_CANCEL_BUTTON_ACTION=Settings changes have been cancelled

#XTOL View Settings Dialog Sort button tooltop text
VSD_SORT_TOOLTIP=Sort

Expand Down
Loading