Skip to content

fix(ui5-suggestion-item-custom): improve accessibility of custom sugg… #13436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivoplashkov merged 2 commits into from
Apr 28, 2026
+10 −3
Merged

fix(ui5-suggestion-item-custom): improve accessibility of custom sugg… #13436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4a9b0
fix(ui5-suggestion-item-custom): improve accessibility of custom sugg…
ivoplashkov Apr 27, 2026
d78d308
fix(ui5-suggestion-item-custom): sync React sample with HTML sample
ivoplashkov Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/website/docs/_samples/main/Input/CustomSuggestions/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const fillInput = (data, value) => {

item.innerHTML = `
<div class='item-content'>
<ui5-icon name="globe"></ui5-icon>
<ui5-icon name="globe" aria-hidden="true"></ui5-icon>
<div class='item-titles'>
<span>${generateHighlightedMarkup(country, value)}</span>
<small>EU</small>
Expand All @@ -51,5 +51,5 @@ const fillInput = (data, value) => {
input.addEventListener("ui5-selection-change", e => {
const text = e.detail.item?.text;

announce(text, "Polite");
announce(text + " EU", "Polite");
})
9 changes: 8 additions & 1 deletion packages/website/docs/_samples/main/Input/CustomSuggestions/sample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { type UI5CustomEvent } from "@ui5/webcomponents-base";
import InputClass from "@ui5/webcomponents/dist/Input.js";
import SuggestionItemCustomClass from "@ui5/webcomponents/dist/SuggestionItemCustom.js";
import IconClass from "@ui5/webcomponents/dist/Icon.js";
import announce from "@ui5/webcomponents-base/dist/util/InvisibleMessage.js";
import "@ui5/webcomponents/dist/features/InputSuggestions.js";
import "@ui5/webcomponents-icons/dist/globe.js";

Expand All @@ -27,6 +28,11 @@ function App() {
const [suggestions, setSuggestions] = useState<string[]>([]);
const [inputValue, setInputValue] = useState("");

const handleSelectionChange = (e: UI5CustomEvent<InputClass, "selection-change">) => {
const text = (e.detail as any).item?.text;
announce(text + " EU", "Polite");
};

const handleInput = (e: UI5CustomEvent<InputClass, "input">) => {
const value = e.currentTarget.value;
setInputValue(value);
Expand Down Expand Up @@ -63,11 +69,12 @@ function App() {
placeholder="Type something ..."
showSuggestions={true}
onInput={handleInput}
onSelectionChange={handleSelectionChange}
>
{suggestions.map((country) => (
<SuggestionItemCustom key={country} text={country}>
<div className="item-content">
<Icon name="globe" />
<Icon name="globe" aria-hidden="true" />
<div className="item-titles">
<span>{country}</span>
<small>EU</small>
Expand Down
Loading