feat(ui5-shellbar): align padding and logo styles with VD spec#13535
Open
NakataCode wants to merge 2 commits into
Open
feat(ui5-shellbar): align padding and logo styles with VD spec#13535NakataCode wants to merge 2 commits into
NakataCode wants to merge 2 commits into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13535--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
ShellBarBranding.csswith the Shell Bar (Horizon) Visual Design specification.Changes
height: 2.25rem(36px) to.ui5-shellbar-branding-rootto cap the branding area at the correct size0.25rem(4px) to0.125rem(2px) top and bottom, as specified0.25remleft /0.5remright (4px / 8px) — already correct.ui5-shellbar-logo-arearight padding from0.5remto0.25remto avoid the double 8px gap that was appearing when no product identifier is present2rem(32px) to1.875rem(30px) with1pxtop/bottompadding-blockbreathing space, so the logo renders at the correct 30px height without being clippedwidth: autoto ensure proportional scaling regardless of the logo's original dimensionsSpec reference
Shell Bar (Horizon) — Branding section:
2.25rem, padding top/bottom2px, padding left0.25rem(4px), padding right0.5rem(8px)2rem, 1px top/bottom breathing space, padding left/right0.25rem(4px)0.25rem(4px)JIRA: BGSOFUIPIRIN-7065