Skip to content

chore: split tests #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nnaydenow merged 3 commits into from
Jun 1, 2026
Merged

chore: split tests #13597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888bd1d
chore: tests
nnaydenow May 27, 2026
749da58
chore: restore date tests files
nnaydenow May 27, 2026
23dc535
Merge branch 'main' into test-stab
nnaydenow Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions packages/fiori/cypress/specs/SideNavigation.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,33 +939,39 @@ describe("Side Navigation interaction", () => {
</SideNavigation>
);

cy.get("#parentItem").realClick();
[
const cases: Array<{ selector: () => Cypress.Chainable, expectedCallCount: number }> = [
{
element: cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-item][text='2']").shadow()
.find(".ui5-sn-item"),
selector: () => cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-item][text='2']").shadow().find(".ui5-sn-item"),
expectedCallCount: 1,
},
{
element: cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-sub-item][text='2.1']"),
selector: () => cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-sub-item][text='2.1']"),
expectedCallCount: 1,
},
{
element: cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-sub-item][text='2.2']"),
selector: () => cy.get("#sideNav").shadow().find("[ui5-responsive-popover] [ui5-side-navigation-sub-item][text='2.2']"),
expectedCallCount: 0,
},
].forEach(({ element, expectedCallCount }) => {
];

cases.forEach(({ selector, expectedCallCount }) => {
cy.get("#sideNav")
.then(sideNav => {
sideNav.get(0).addEventListener("ui5-selection-change", cy.stub().as("selectionChangeHandler"));
});

// act
// open the popover fresh each iteration
cy.get("#parentItem").realClick();
element.realClick();
cy.get("#sideNav").shadow().find("[ui5-responsive-popover]").should("be.visible");

// act
selector().realClick();

// assert
cy.get("@selectionChangeHandler", { timeout: 1000 }).should("have.callCount", expectedCallCount);
cy.get("@selectionChangeHandler").should("have.callCount", expectedCallCount);

// close popover before next iteration (click outside)
cy.get("body").click(0, 0);
});
});

Expand All @@ -978,6 +984,8 @@ describe("Side Navigation interaction", () => {
);

cy.get("#item").realClick();
// wait for first selection to settle before clicking again
cy.get("@selectionChangeHandler").should("have.been.calledOnce");
cy.get("#item").realClick();

cy.get("@selectionChangeHandler").should("have.been.calledOnce");
Expand Down Expand Up @@ -1021,14 +1029,17 @@ describe("Side Navigation interaction", () => {
.realClick();

cy.get("@overflowMenu")
.should("be.not.visible");
.should("not.be.visible");

cy.get("[ui5-side-navigation-item][text='Home 6']")
.should("be.focused");

cy.get("@itemOverflow")
.realClick();

cy.get("@overflowMenu")
.should("be.visible");

cy.get("@overflowMenu")
.find("[ui5-navigation-menu-item][text='Home 7']")
.realClick();
Expand Down
Loading
Loading