Skip to content

fix(ui5-expandable-text): fix using "white-space" style in the component#13599

Merged
TeodorTaushanov merged 10 commits into
mainfrom
exp_text_preverve
Jun 4, 2026
Merged

fix(ui5-expandable-text): fix using "white-space" style in the component#13599
TeodorTaushanov merged 10 commits into
mainfrom
exp_text_preverve

Conversation

@TeodorTaushanov
Copy link
Copy Markdown
Member

@TeodorTaushanov TeodorTaushanov commented May 27, 2026

white-space style in inherited in the internal ui5-text component and in the popover text.

fix inheritance of font-family and font-size in the popover text

fixes #12970
JIRA: BGSOFUIRODOPI-3611

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-expandable-text): inherit white-space fix(ui5-expandable-text): fix using "white-space" style in the component May 27, 2026
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented May 27, 2026

🧹 Preview deployment cleaned up: https://pr-13599--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 27, 2026 13:39 Inactive
@TeodorTaushanov TeodorTaushanov requested a review from a team May 28, 2026 07:34
Copy link
Copy Markdown
Member

@duygu-rmdn duygu-rmdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide cypress tests

Comment thread packages/main/src/themes/ExpandableText.css
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview June 2, 2026 08:38 Inactive
Copy link
Copy Markdown
Member

@duygu-rmdn duygu-rmdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks good to me

Comment thread packages/main/cypress/specs/ExpandableText.cy.tsx Outdated
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview June 3, 2026 10:27 Inactive
duygu-rmdn
duygu-rmdn previously approved these changes Jun 3, 2026
@TeodorTaushanov TeodorTaushanov merged commit 52a0985 into main Jun 4, 2026
12 checks passed
@TeodorTaushanov TeodorTaushanov deleted the exp_text_preverve branch June 4, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: ExpandableText — Add maxWidth For Responsive Popover And Preserve Whitespaces

3 participants