Linting fixes

Author: dw-ukhsa

cms/dashboard/viewsets.py

@@ -3,7 +3,6 @@
 
 from django.urls import path
 from django.urls.resolvers import RoutePattern
-from django.db.models import Q
 from drf_spectacular.utils import extend_schema
 from rest_framework.request import Request
 from rest_framework.response import Response
@@ -90,14 +89,15 @@ def get_queryset(self):
                     page_ptr__in=queryset,
                 ).values_list("page_ptr_id", flat=True)
 
-                public_metrics_doc_child_page_ids = MetricsDocumentationChildEntry.objects.filter(
-                    is_public=True,
-                    page_ptr__in=queryset,
-                ).values_list("page_ptr_id", flat=True)
+                public_metrics_doc_child_page_ids = (
+                    MetricsDocumentationChildEntry.objects.filter(
+                        is_public=True,
+                        page_ptr__in=queryset,
+                    ).values_list("page_ptr_id", flat=True)
+                )
 
                 always_public_page_ids = queryset.not_type(
-                    TopicPage,
-                    MetricsDocumentationChildEntry
+                    TopicPage, MetricsDocumentationChildEntry
                 ).values_list("id", flat=True)
 
                 allowed_page_ids = [

tests/integration/cms/dashboard/test_viewsets.py

@@ -321,7 +321,7 @@ def setup_pages(self):
     @staticmethod
     def _get_response_titles(response) -> set[str]:
         return {item["title"] for item in response.data["items"]}
-    
+
     @mock.patch("cms.dashboard.viewsets.AUTH_ENABLED", True)
     def test_anonymous_search_returns_public_pages(self, setup_pages):
         """
@@ -377,7 +377,9 @@ def test_auth_disabled_returns_unfiltered_pages(self, setup_pages):
         assert "Regression Search Private Metric 2" in titles
 
     @mock.patch("cms.dashboard.viewsets.AUTH_ENABLED", True)
-    def test_restricted_user_search_returns_public_and_permitted_pages(self, setup_pages):
+    def test_restricted_user_search_returns_public_and_permitted_pages(
+        self, setup_pages
+    ):
         """
         Given an athenticated restricted user has access to some private pages
         When the list `GET /api/pages/?search=<term>` endpoint is hit
@@ -387,8 +389,7 @@ def test_restricted_user_search_returns_public_and_permitted_pages(self, setup_p
         mock_user = mock.MagicMock()
         mock_user.username = "restricted-user"
         mock_user.permission_sets = MockPermissionSets(
-            [{"theme": {"id": "1"}, "sub_theme": {"id": "-1"}}],
-            has_global_access=False
+            [{"theme": {"id": "1"}, "sub_theme": {"id": "-1"}}], has_global_access=False
         )
 
         api_client = APIClient()
@@ -411,4 +412,4 @@ def test_restricted_user_search_returns_public_and_permitted_pages(self, setup_p
 
         assert "Regression Search Private Topic" in titles
         assert "Regression Search Private Metric" not in titles
-        assert "Regression Search Private Metric 2" in titles
+        assert "Regression Search Private Metric 2" in titles