Skip to content

CDD 3174 - Downloads v2 endpoint#3221

Open
dandammann wants to merge 275 commits into
mainfrom
CDD-3174
Open

CDD 3174 - Downloads v2 endpoint#3221
dandammann wants to merge 275 commits into
mainfrom
CDD-3174

Conversation

@dandammann

@dandammann dandammann commented May 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR includes the following:

See https://ukhsa.atlassian.net/browse/CDD-3174

Type of change

Please select the options that are relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • [ ] I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

luketowell and others added 30 commits March 17, 2026 17:15
@luketowell
CDD-3175: populate the Topic dropdown
98d47ae
@luketowell
Merge branch 'main' into task/CDD-3175-permission-sets-cms
3c0a0b7
@luketowell
Wire up geographyType model
2c01f79
@luketowell
Update theme functionality to pull available themes from the db via t…
96526f5 
…he metrics interface.
@luketowell
CDD-3175: added endpoints for retrieving subtheme/topics/metrics and …
7446975 
…wired up javascript to call endpoints.
@luketowell
Update the model and the permission_set javascript when handling wild…
e4bc21a 
…card selection
@luketowell
Update to add serializer to handle request and response for subthemes…
9c7ca66 
… and update to subthemes to handle querying db
@luketowell
CDD-3175: updated the JS to add wildcard and empty object options
5b2f370
@luketowell
CDD-3175: Updated the topics and metrics endpoints to retrieve data f…
b362c43 
…rom the DB
@luketowell
CDD-3175: wired up the logic for selecting geography types
fd83953
@luketowell
CDD-3175: update permission set for geographies
6d37e21
@luketowell
CDD-3175: updates for limiting the creation of duplicate permission sets
ad8123c
@luketowell
CDD-3175: updates for handling the naming of permission sets
60d108f
@luketowell
CDD-3085: updated validations and wildcard functionality
57c71cb
@luketowell
Merge branch 'main' into task/CDD-3175-permission-sets-cms
085bf1c
@luketowell
CDD-3175: update migrations and add tidy up javascript and validation
aec0c5c
@luketowell
CDD-3175: remove console logs from javascript
d679e8d
@luketowell
CDD-3175: Update PermissionSet model
9875ae4
@luketowell
CDD-3175: Update wagtail hooks
5be1690
@luketowell
CDD-3175: remove print statements and tidy up field_choice_callables
dc45208
@luketowell
CDD-3175: Update method descriptions
8178091
@luketowell
CDD-3175: tidied up the geography serializer
cc5bd4a
@luketowell
CDD-3175: formatting
e07efdf
@luketowell
Update documentation
6995b9e
@luketowell
CDD-3175: linting
843f340
@luketowell
CDD-3175: tests
7b91090
@kathryn-dale
CDD-3176: Add initial model
3ee2a70
@kathryn-dale @luketowell
CDD-3175: Initial Commit
6017395
@kathryn-dale @luketowell
Create initial permission set
0b2c039
@kathryn-dale @luketowell
Add conditional sub_theme dropdown
527b15f
@dandammann dandammann requested review from jrdh and kathryn-dale June 9, 2026 15:22
jrdh
jrdh reviewed Jun 10, 2026
View reviewed changes
Comment thread metrics/domain/models/plots.py Outdated
jrdh
jrdh reviewed Jun 10, 2026
View reviewed changes
Comment thread metrics/domain/models/common.py
mattjreynolds
mattjreynolds reviewed Jun 10, 2026
View reviewed changes
Comment thread metrics/domain/models/plots.py Outdated
Comment thread tests/integration/metrics/data/managers/core_models/test_time_series.py
Comment thread common/auth/cognito_jwt/backend.py Outdated
Comment thread common/auth/permissions.py Outdated
Comment thread metrics/data/managers/core_models/time_series.py Outdated
Comment thread tests/unit/common/auth/test_permissions.py Outdated
Comment thread tests/unit/common/auth/test_permissions.py Outdated
Comment thread tests/unit/common/auth/test_permissions.py
@dandammann dandammann requested review from jrdh and mattjreynolds June 10, 2026 18:59
jrdh
jrdh approved these changes Jun 16, 2026
View reviewed changes

@jrdh jrdh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sonarqubecloud

sonarqubecloud Bot commented Jun 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrdh jrdh jrdh approved these changes

@mattjreynolds mattjreynolds mattjreynolds approved these changes

@kathryn-dale kathryn-dale kathryn-dale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@dandammann @jrdh @mattjreynolds @kathryn-dale @luketowell @abdihakim92x1 @tushortz @aidan @itsthatianguy @sahmed06