CDD-3440: Add regression coverage for /api/pages/ filtering and search#3267
CDD-3440: Add regression coverage for /api/pages/ filtering and search#3267dw-ukhsa wants to merge 4 commits into
/api/pages/ filtering and search#3267Conversation
There was a problem hiding this comment.
Looks good 😎
It needs a rebase onto latest main, and it's failing the linting CI check, you can fix this by just running the linting fix in the uhd scripts:
source uhd.sh
uhd quality format
Nice work on cleaning up the tech debt in the queryset filtering in cms/dashboard/viewsets.py too, that's much more readable now 🙌
I've double checked that the integration tests pass even without those improvements, but given that we are changing the code as well as the tests we should run this through QA just to get sign off from Shahrukh that we don't have any regressions @sahmed06
36ff66f to
b627c48
Compare
|
@mattjreynolds |
|



Description
This PR includes the following:
GET /api/pages/filtering and search behaviourAUTH_ENABLED=True, ensuring private pages matching the search term are excludedAUTH_ENABLED=False, ensuring/api/pagesreturns the unfiltered public-prod resultAUTH_ENABLED=Truefiltering path to return a Wagtail-search-compatibleid__inquerysetFixes #CDD-3440
Type of change
Please select the options that are relevant.
Checklist:
Testing: