Feature/variant calling#60
Merged
Merged
Conversation
ellendejong
reviewed
May 29, 2026
ellendejong
left a comment
Collaborator
There was a problem hiding this comment.
Nice to see this extension to the pipeline. 👍🏼
ellendejong
requested changes
Jun 1, 2026
ellendejong
left a comment
Collaborator
There was a problem hiding this comment.
And some feedback regarding GTF2BED.
ellendejong
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RNA-seq variant calling subworkflow
This PR adds a new subworkflow for variant calling on RNA-seq data, following GATK best practices for RNA-seq short variant discovery.
What's included
BAM_VARIANT_CALLINGthat takes a deduplicated BAM and produces a filtered VCFSplitNCigarReads— splits reads spanning splice junctionsHaplotypeCaller— variant calling with--dont-use-soft-clipped-basesMergeVcfs— gathers scattered VCFs per sampleVariantFiltration— applies GATK-recommended RNA-seq filters (FS, QD, SnpCluster)--gatk_interval_scatter_count, default 25) soSplitNCigarReadsandHaplotypeCallerrun in parallel, drastically reducing wall timeSTAR_ALIGNnow correctly excludes bam and fastq files.Notes for reviewers
BaseRecalibrator+ApplyBQSRin a follow-up PR once we've assessed whether it meaningfully improves results for our dataGTF2BED→BedToIntervalList)Testing
nf-test test subworkflows/local/bam_variant_calling/