linting setup#13
Open
Jorisvansteenbrugge wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules repository setup with linting GitHub actions. Some additional context is available in the README. Important for this review is this bit, which is a debatable design choice.
I've included two example modules that are used in the PRS pipeline to illustrate how the linting tests are performed in practice.
The repository can be tested locally. To view the available modules in this feature branch:
The
--branchflag defaults to main/master.To install the modules from this feature branch in a pipeline:
Module versions will be tagged in the
modules.jsonfile of the pipeline. Modules from this repository can co-exist with modules from the nf-core repository (as long as they don't have the same name). Updating modules can similarly be done using the same CLI.For example: