Fix robot message type POPUP (UniversalRobots#335)

urfeex · web-flow · commit 07715e0b2929 · 2025-06-02T11:04:27.000+02:00
Before it was using the name PROGRAM_STATE_MESSAGE_VARIABLE_UPDATE As far as I can see that error has been there for all eternity, but that type es never used anywhere. Strictly speaking, this would be breaking API, but the old naming was clearly wrong, so users should not rely on that faulty behavior. Also parsing that type is not implemented in the library, so this is most probably not used by anybody. That would be my argument to make that change without major-bumping the library. @urrsk @urmahp would you agree?
diff --git a/include/ur_client_library/primary/robot_message.h b/include/ur_client_library/primary/robot_message.h
@@ -42,7 +42,7 @@ enum class RobotMessagePackageType : uint8_t
 {
   ROBOT_MESSAGE_TEXT = 0,
   ROBOT_MESSAGE_PROGRAM_LABEL = 1,
-  PROGRAM_STATE_MESSAGE_VARIABLE_UPDATE = 2,
+  ROBOT_MESSAGE_POPUP = 2,
   ROBOT_MESSAGE_VERSION = 3,
   ROBOT_MESSAGE_SAFETY_MODE = 5,
   ROBOT_MESSAGE_ERROR_CODE = 6,

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ enum class RobotMessagePackageType : uint8_t`
`42`	`42`	`{`
`43`	`43`	`ROBOT_MESSAGE_TEXT = 0,`
`44`	`44`	`ROBOT_MESSAGE_PROGRAM_LABEL = 1,`
`45`		`- PROGRAM_STATE_MESSAGE_VARIABLE_UPDATE = 2,`
	`45`	`+ ROBOT_MESSAGE_POPUP = 2,`
`46`	`46`	`ROBOT_MESSAGE_VERSION = 3,`
`47`	`47`	`ROBOT_MESSAGE_SAFETY_MODE = 5,`
`48`	`48`	`ROBOT_MESSAGE_ERROR_CODE = 6,`