Skip to content

Commit 83aeea4

Browse files
authored
Add deprecation warning for scaled JTC (UniversalRobots#1660)
It will be removed in Lyrical, so it makes sense to add a deprecation warning already.
1 parent 6f725cc commit 83aeea4

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

ur_controllers/doc/index.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ down by the controller).
5050
ur_controlers/ScaledJointTrajectoryController
5151
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5252

53+
.. note::
54+
The upstream joint_trajectory_controller has been updated to support the scaling feature
55+
explained below. Hence, we have decided to deprecate the scaled joint trajectory controller.
56+
It will get removed in ROS Lyrical Luth.
57+
5358
These controllers work similar to the well-known
5459
`joint_trajectory_controller <https://control.ros.org/master/doc/ros2_controllers/joint_trajectory_controller/doc/userdoc.html>`_.
5560

ur_controllers/src/scaled_joint_trajectory_controller.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ controller_interface::CallbackReturn ScaledJointTrajectoryController::on_init()
5252
get_node()->set_parameter(
5353
rclcpp::Parameter("speed_scaling.state_interface", scaled_params_.speed_scaling_interface_name));
5454
}
55+
56+
RCLCPP_WARN(get_node()->get_logger(), "DEPRECATION WARNING: Using the scaled joint trajectory controller is "
57+
"considered deprecated. It will get removed with ROS Lyrical Luth. Please "
58+
"use the joint_trajectory_controller that supports the same features.");
5559
return JointTrajectoryController::on_init();
5660
}
5761

0 commit comments

Comments
 (0)