Skip to content

Commit 720c500

Browse files
HadenSmithHadenSmith
committed
fix(nb03): replace non-existent SampleSize/BurnInSamples in commented hints
The commented 'Optional: Configure sampler settings' lines suggested sampler.SampleSize and sampler.BurnInSamples, neither of which exists on MCMCSampler. Real properties are Iterations and WarmupIterations (verified MCMCSampler.cs lines 140 and 153). A learner uncommenting the old hints would silently create phantom Python attributes via pythonnet. Fixed the hint text only; no change to execution path.
1 parent 6dc23e8 commit 720c500

1 file changed

Lines changed: 47 additions & 47 deletions

File tree

‎notebooks/03_mcmc_basics.ipynb‎

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@
109109
"id": "046fb0a3",
110110
"metadata": {
111111
"execution": {
112-
"iopub.execute_input": "2026-04-23T19:22:36.116059Z",
113-
"iopub.status.busy": "2026-04-23T19:22:36.114777Z",
114-
"iopub.status.idle": "2026-04-23T19:22:37.765041Z",
115-
"shell.execute_reply": "2026-04-23T19:22:37.765041Z"
112+
"iopub.execute_input": "2026-04-23T21:32:19.608974Z",
113+
"iopub.status.busy": "2026-04-23T21:32:19.608974Z",
114+
"iopub.status.idle": "2026-04-23T21:32:20.766682Z",
115+
"shell.execute_reply": "2026-04-23T21:32:20.766682Z"
116116
}
117117
},
118118
"outputs": [
@@ -154,10 +154,10 @@
154154
"id": "8f4b903e",
155155
"metadata": {
156156
"execution": {
157-
"iopub.execute_input": "2026-04-23T19:22:37.768047Z",
158-
"iopub.status.busy": "2026-04-23T19:22:37.767048Z",
159-
"iopub.status.idle": "2026-04-23T19:22:37.773185Z",
160-
"shell.execute_reply": "2026-04-23T19:22:37.773185Z"
157+
"iopub.execute_input": "2026-04-23T21:32:20.766682Z",
158+
"iopub.status.busy": "2026-04-23T21:32:20.766682Z",
159+
"iopub.status.idle": "2026-04-23T21:32:20.774600Z",
160+
"shell.execute_reply": "2026-04-23T21:32:20.774600Z"
161161
}
162162
},
163163
"outputs": [
@@ -201,10 +201,10 @@
201201
"id": "04138f5a",
202202
"metadata": {
203203
"execution": {
204-
"iopub.execute_input": "2026-04-23T19:22:37.775192Z",
205-
"iopub.status.busy": "2026-04-23T19:22:37.775192Z",
206-
"iopub.status.idle": "2026-04-23T19:22:37.943742Z",
207-
"shell.execute_reply": "2026-04-23T19:22:37.943742Z"
204+
"iopub.execute_input": "2026-04-23T21:32:20.774600Z",
205+
"iopub.status.busy": "2026-04-23T21:32:20.774600Z",
206+
"iopub.status.idle": "2026-04-23T21:32:20.907085Z",
207+
"shell.execute_reply": "2026-04-23T21:32:20.907085Z"
208208
}
209209
},
210210
"outputs": [
@@ -275,10 +275,10 @@
275275
"id": "68d30485",
276276
"metadata": {
277277
"execution": {
278-
"iopub.execute_input": "2026-04-23T19:22:37.946759Z",
279-
"iopub.status.busy": "2026-04-23T19:22:37.946759Z",
280-
"iopub.status.idle": "2026-04-23T19:22:37.954053Z",
281-
"shell.execute_reply": "2026-04-23T19:22:37.954053Z"
278+
"iopub.execute_input": "2026-04-23T21:32:20.907085Z",
279+
"iopub.status.busy": "2026-04-23T21:32:20.907085Z",
280+
"iopub.status.idle": "2026-04-23T21:32:20.915658Z",
281+
"shell.execute_reply": "2026-04-23T21:32:20.915658Z"
282282
}
283283
},
284284
"outputs": [
@@ -336,10 +336,10 @@
336336
"id": "e8aca3ab",
337337
"metadata": {
338338
"execution": {
339-
"iopub.execute_input": "2026-04-23T19:22:37.957074Z",
340-
"iopub.status.busy": "2026-04-23T19:22:37.956063Z",
341-
"iopub.status.idle": "2026-04-23T19:22:37.964188Z",
342-
"shell.execute_reply": "2026-04-23T19:22:37.964188Z"
339+
"iopub.execute_input": "2026-04-23T21:32:20.915658Z",
340+
"iopub.status.busy": "2026-04-23T21:32:20.915658Z",
341+
"iopub.status.idle": "2026-04-23T21:32:20.922556Z",
342+
"shell.execute_reply": "2026-04-23T21:32:20.922556Z"
343343
}
344344
},
345345
"outputs": [
@@ -414,10 +414,10 @@
414414
"id": "165d8ce2",
415415
"metadata": {
416416
"execution": {
417-
"iopub.execute_input": "2026-04-23T19:22:37.967196Z",
418-
"iopub.status.busy": "2026-04-23T19:22:37.966200Z",
419-
"iopub.status.idle": "2026-04-23T19:22:47.181149Z",
420-
"shell.execute_reply": "2026-04-23T19:22:47.180831Z"
417+
"iopub.execute_input": "2026-04-23T21:32:20.922556Z",
418+
"iopub.status.busy": "2026-04-23T21:32:20.922556Z",
419+
"iopub.status.idle": "2026-04-23T21:32:29.496509Z",
420+
"shell.execute_reply": "2026-04-23T21:32:29.496509Z"
421421
}
422422
},
423423
"outputs": [
@@ -443,8 +443,8 @@
443443
"sampler.ParallelizeChains = False\n",
444444
"\n",
445445
"# Optional: Configure sampler settings\n",
446-
"# sampler.SampleSize = 5000 # Number of samples (default is good)\n",
447-
"# sampler.BurnInSamples = 1000 # Burn-in period\n",
446+
"# sampler.Iterations = 5000 # Total iterations; default is fine for this example\n",
447+
"# sampler.WarmupIterations = 1000 # Warmup (burn-in) length\n",
448448
"\n",
449449
"# Initialize sampler at the Maximum a Posteriori (MAP) estimate and covariance matrix (optional, can improve convergence)\n",
450450
"sampler.Initialize = MCMCSampler.InitializationType.MAP\n",
@@ -477,10 +477,10 @@
477477
"id": "59d808ac",
478478
"metadata": {
479479
"execution": {
480-
"iopub.execute_input": "2026-04-23T19:22:47.184150Z",
481-
"iopub.status.busy": "2026-04-23T19:22:47.184150Z",
482-
"iopub.status.idle": "2026-04-23T19:22:47.577027Z",
483-
"shell.execute_reply": "2026-04-23T19:22:47.576508Z"
480+
"iopub.execute_input": "2026-04-23T21:32:29.496509Z",
481+
"iopub.status.busy": "2026-04-23T21:32:29.496509Z",
482+
"iopub.status.idle": "2026-04-23T21:32:29.801456Z",
483+
"shell.execute_reply": "2026-04-23T21:32:29.801456Z"
484484
}
485485
},
486486
"outputs": [
@@ -543,10 +543,10 @@
543543
"id": "8b653f22",
544544
"metadata": {
545545
"execution": {
546-
"iopub.execute_input": "2026-04-23T19:22:47.579038Z",
547-
"iopub.status.busy": "2026-04-23T19:22:47.579038Z",
548-
"iopub.status.idle": "2026-04-23T19:22:47.592532Z",
549-
"shell.execute_reply": "2026-04-23T19:22:47.592532Z"
546+
"iopub.execute_input": "2026-04-23T21:32:29.801456Z",
547+
"iopub.status.busy": "2026-04-23T21:32:29.801456Z",
548+
"iopub.status.idle": "2026-04-23T21:32:29.814695Z",
549+
"shell.execute_reply": "2026-04-23T21:32:29.814695Z"
550550
}
551551
},
552552
"outputs": [
@@ -682,10 +682,10 @@
682682
"id": "eb20ce0a",
683683
"metadata": {
684684
"execution": {
685-
"iopub.execute_input": "2026-04-23T19:22:47.595540Z",
686-
"iopub.status.busy": "2026-04-23T19:22:47.594541Z",
687-
"iopub.status.idle": "2026-04-23T19:22:56.424125Z",
688-
"shell.execute_reply": "2026-04-23T19:22:56.423108Z"
685+
"iopub.execute_input": "2026-04-23T21:32:29.814695Z",
686+
"iopub.status.busy": "2026-04-23T21:32:29.814695Z",
687+
"iopub.status.idle": "2026-04-23T21:32:36.457469Z",
688+
"shell.execute_reply": "2026-04-23T21:32:36.457469Z"
689689
}
690690
},
691691
"outputs": [
@@ -747,10 +747,10 @@
747747
"id": "2a1a8d09",
748748
"metadata": {
749749
"execution": {
750-
"iopub.execute_input": "2026-04-23T19:22:56.427131Z",
751-
"iopub.status.busy": "2026-04-23T19:22:56.426138Z",
752-
"iopub.status.idle": "2026-04-23T19:22:57.138235Z",
753-
"shell.execute_reply": "2026-04-23T19:22:57.138235Z"
750+
"iopub.execute_input": "2026-04-23T21:32:36.457469Z",
751+
"iopub.status.busy": "2026-04-23T21:32:36.457469Z",
752+
"iopub.status.idle": "2026-04-23T21:32:36.956715Z",
753+
"shell.execute_reply": "2026-04-23T21:32:36.956715Z"
754754
}
755755
},
756756
"outputs": [
@@ -937,10 +937,10 @@
937937
"id": "066f0505",
938938
"metadata": {
939939
"execution": {
940-
"iopub.execute_input": "2026-04-23T19:22:57.140747Z",
941-
"iopub.status.busy": "2026-04-23T19:22:57.140747Z",
942-
"iopub.status.idle": "2026-04-23T19:22:57.518917Z",
943-
"shell.execute_reply": "2026-04-23T19:22:57.518917Z"
940+
"iopub.execute_input": "2026-04-23T21:32:36.956715Z",
941+
"iopub.status.busy": "2026-04-23T21:32:36.956715Z",
942+
"iopub.status.idle": "2026-04-23T21:32:37.275812Z",
943+
"shell.execute_reply": "2026-04-23T21:32:37.275812Z"
944944
}
945945
},
946946
"outputs": [
@@ -1053,7 +1053,7 @@
10531053
],
10541054
"metadata": {
10551055
"kernelspec": {
1056-
"display_name": ".venv",
1056+
"display_name": "Python 3 (ipykernel)",
10571057
"language": "python",
10581058
"name": "python3"
10591059
},

0 commit comments

Comments
 (0)