Add individual reviewer gating and merge-gate status to review workflow#109
Merged
Conversation
…view workflow - Rewrite stage-progression.yml with a hidden state comment that tracks which individuals are assigned to each review stage; approvals only advance the stage when the approver is in the assigned list for the current stage, so drive-by approvals are logged but don't trample the workflow - Introduce a review-workflow commit status managed by the bot as the merge gate: pending during active reviews, success on stage:ready-to-merge, success immediately on lane:editorial-fix, and success for non-docs PRs after CI passes - Handle synchronize events without resetting the stage — revisions during a review round are expected, so re-set the commit status on the new head SHA and ping the stage's assigned reviewers to backcheck - Intercept docs-touching PRs whose branches don't follow docs/* naming and route them through lane assignment - Add admin:advance-to-director override label for Lane 1 PRs at the technical edit stage - Add a CI-passed "admin may merge" comment for non-docs PRs - Filter deploy.yml by the same path allowlist as pr-preview.yml so merges to main that don't affect site output no longer redeploy - Add concurrency blocks to stage-progression.yml and pr-preview.yml - Update reviewer/director workflow planning doc to use Comment for revision-cycle feedback instead of Request changes
|
✅ CI build passed for commit This PR does not touch documentation content under @usace-rmc/docs-admin may merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stage-progression.ymlwith per-individual reviewer gating: a hidden bot-managed state comment tracks who is assigned to each review stage, and approvals only advance the stage when the approver is in the assigned list — drive-by approvals are logged but don't trample the workflowreview-workflowcommit status managed by the bot as the merge gate (to be added to branch protection after this PR merges): pending during active reviews, success onstage:ready-to-merge, immediate success onlane:editorial-fix, success for non-docs PRs after CI passesdocs/*naming and route them through lane assignment; handlesynchronizewithout resetting the stage; addadmin:advance-to-directoroverride label for Lane 1 PRs stuck at the technical edit stagedeploy.ymlby the same path allowlist aspr-preview.ymlso merges tomainthat don't affect site output no longer redeploy; add concurrency blocks tostage-progression.ymlandpr-preview.yml