Skip to content

Commit 4957065

Browse files
Feature/7 add indication of auto refresh on job details page (#175)
* Created Loading spinner component * Add loading spinner on job status on details page * Changed LoadingSpinner component to remove unnecessary div
1 parent 35dbf3e commit 4957065

2 files changed

Lines changed: 21 additions & 2 deletions

File tree

ui/src/features/jobs-list/JobDetail.tsx

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { PropsWithChildren } from "react";
2+
import LoadingSpinner from "../../shared/components/LoadingSpinner";
23
import { JobDetails } from "./useJobDetails";
34

45
const jobFields: (keyof JobDetails)[] = [
@@ -33,7 +34,18 @@ function JobDetail({ job }: JobDetailProps) {
3334
: "col-span-1";
3435
return (
3536
<JobDetailField key={field} field={field} className={className}>
36-
{job[field]}
37+
{field === "jobStatus" ? (
38+
job.jobStatus !== "Completed" && job.jobStatus !== "Failed" ? (
39+
<span className="inline-flex items-center gap-2">
40+
<span>{job.jobStatus}</span>
41+
<LoadingSpinner />
42+
</span>
43+
) : (
44+
job.jobStatus
45+
)
46+
) : (
47+
job[field]
48+
)}
3749
</JobDetailField>
3850
);
3951
})}
@@ -57,4 +69,4 @@ const JobDetailField = ({
5769
</span>
5870
);
5971

60-
export default JobDetail;
72+
export default JobDetail;
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { AiOutlineLoading } from "react-icons/ai";
2+
3+
const LoadingSpinner = () => (
4+
<AiOutlineLoading className="animate-spin text-xl" />
5+
);
6+
7+
export default LoadingSpinner;

0 commit comments

Comments
 (0)