Add redirect override for auth login#239
Merged
Merged
Conversation
|
I found this redirect code does not respect the query string and does not return to the page properly when a query string is needed.
|
Collaborator
|
A bit out of my wheelhouse, so claude is helping me. Overall looks good, using session storage is a good way to to store the return URL. The auth docs need to be updated though (this came after this PR was started). The The export interface AuthLoginOptions {
/**
* In-app URL to return the user to after sign-in. Stored locally and
* restored after the callback. It is NOT sent to the identity provider.
* The registered OIDC callback stays whatever you set as `redirectUri`
* on createKeycloakAuthMethod().
*/
redirectUri?: string;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


@tsressin