Skip to content

Commit 3cbdc75

Browse files
authored
Merge pull request #2 from USACE-WaterManagement/dev
Standard install directory
2 parents 60d7db2 + 37e3b3d commit 3cbdc75

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ jobs:
153153
} else {
154154
"${{ github.ref_name }}" -replace "^v", ""
155155
}
156-
$finalDir = "pythonCWMS$version"
156+
$finalDir = "pythonCWMS"
157157
158158
Write-Host "Creating final directory: $finalDir"
159159
Write-Host "Source WinPython directory: $($winpythonDir.Name)"

jython_scripts/install_python.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,8 @@ def _cleanup_destination_dir(self, path):
371371
self._update_ui(lambda: self.log_area.append("Cleaned up: {}\n".format(path)))
372372
except Exception, e:
373373
self._update_ui(lambda: self.log_area.append("Warning: Failed to clean up directory {}: {}\n".format(path, e)))
374-
self._update_ui(lambda: JOptionPane.showMessageDialog(self, "Warning: Could not fully clean up directory {}. Please remove it manually if needed.\nError: {}".format(path, e), "Cleanup Warning", JOptionPane.WARNING_MESSAGE))
374+
self._update_ui(lambda: JOptionPane.showMessageDialog(self, "Warning: Could not fully clean up directory {}. Please close any open python instances and " \
375+
"try again or remove it manually if needed.\nError: {}".format(path, e), "Cleanup Warning", JOptionPane.WARNING_MESSAGE))
375376

376377

377378
def _run_installation_in_thread(self, current_python_7z_url, current_expected_sha256_hash, current_destination_dir, current_env_var_name, current_python_exe_sub_dir, seven_z_exe_path):

0 commit comments

Comments
 (0)