Repsond to Options request with reasonable values.#1289
Merged
Conversation
krowvin
approved these changes
Sep 3, 2025
Collaborator
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Looks good. Pending the path wildcard is actually */ and not **/ or something
| ctx.json(errResponse); | ||
| }) | ||
| .routes(this::configureRoutes) | ||
| .options("/*", ctx -> { |
Collaborator
There was a problem hiding this comment.
I'm assuming this wildcards to all paths and sub paths and will also include all path versions when that comes along
Contributor
Author
There was a problem hiding this comment.
That's how it behaved in the tests. Hopefully it stays that way in future versions.
Contributor
Author
|
@dennisgsmith this should be deployed in -dev now if you want to try testing against https://water.dev.cwbi.us/cwms-data/. |
MikeNeilson
added a commit
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175.
Reported a while ago but saw @dennisgsmith implementing some workarounds (https://github.com/USACE/instrumentation-api/pull/281) which really shouldn't be necessary.