CWMSVUE-600 Updating effective data retrieval to not include aliases#1295
Merged
Conversation
rma-bryson
force-pushed
the
bugfix/CWMSVUE-600_ratings
branch
2 times, most recently
from
047d1eb to
84fc8c0
Compare
Collaborator
|
I think you should add some comments so its clear how this works. 1 query to build the non-alias list and then skipping results from the ResultSet if its an alias. Its easy to implement but not ideal. Might be an acceptable trade-off. Performance will depend on how many aliased items there typically are. |
…separate connection.
…tion for catRatings call
rma-rripken
approved these changes
Sep 5, 2025
rma-bryson
force-pushed
the
bugfix/CWMSVUE-600_ratings
branch
from
76e1841 to
fe16cce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.