Conversation
|
UI still works, also corrected the behavior for the swagger-docs link, previous fix did not quite do the trick. |
MikeNeilson
force-pushed
the
devops/package-updates
branch
from
4e7122b to
6a6657e
Compare
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Wondering about the version downgrade on the generator before you merge
| }, | ||
| "devDependencies": { | ||
| "@openapitools/openapi-generator-cli": "^2.15.3", | ||
| "@openapitools/openapi-generator-cli": "^0.0.6", |
There was a problem hiding this comment.
Why are we downgrading the generator? I think we might have picked the wrong version because this could introduce some unforeseen security issues going this far back?
I assumed it might be because of the old javalin/java version but wanted to make sure.
There was a problem hiding this comment.
Huh, thanks, didn't catch that. I'm not sure what happened there, I ran npm audit fix --force might have had something to do with the force, but definitely going backwards there.
| globalThis.location.replace(h); | ||
| return null; | ||
| }, | ||
| component: <div />, |
There was a problem hiding this comment.
I think this should be element:
Assuming we are doing this as a 'don't know don't care' because the location.replace will exit the current frontend anyways?
There was a problem hiding this comment.
One of those doesn't really matter, just needs to exist and would get ignored.
2 participants
Am manually testing the CDA GUI now, wanted to get the rest of the build started.
Manually handles several dependabot/security reports that weren't getting updated by the automation.