test: RgbSettlementModule existence + exact-amount checks#80
Merged
Conversation
* refactor(R-C-01): make OutflowRateLimiter unit-testable in isolation * test(R-C-01): unit tests for RateLimiter lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test branch for the RgbSettlementModule beforeFundsOut rework (fix PR:
rgb-opid-amount-binding). beforeFundsOut is now a view proof-of-mint check
that decodes (uint256[] operationIds, uint256[] amounts) and asserts every
id exists in fundsInRecords with an exactly matching amount — no
consumption, no tie to fundsOut.amount. Solvency/replay remain owned by
Bridge.lockedLiquidity + consumedBurnIds.
Changes
paths (records left intact), reverts for AmountMismatch (over/under),
SettlementDataLengthMismatch, mid-array mismatch; empty-array, duplicate-id
(harmless), repeated-call view stability; exact-match-only fuzz.
two-array encoding, replaced FundsOutAmountExceedsFundsIn assertions with
AmountMismatch, and replaced all "record consumed/residual" assertions with
"record unchanged" (permanent proof-of-mint ledger).
seeded/fuzz/mismatch records) so they don't consume vm.prank/vm.expectRevert
when passed inline.