fix(R-C-01, R-M-01): isolated liquidity + outflow rate limit + RGB opId/amount binding#84
Merged
sh3ifu merged 10 commits intoJun 30, 2026
Merged
Conversation
* test: RgbSettlementModule existence + exact-amount checks * Test/rate limiter lib unit tests (#81) * refactor(R-C-01): make OutflowRateLimiter unit-testable in isolation * test(R-C-01): unit tests for RateLimiter lib
sh3ifu
changed the title
sh3ifu
changed the base branch from
dev
to
test/remove-obsolete-executeBatch-repro
sh3ifu
merged commit c533434
into
test/remove-obsolete-executeBatch-repro
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands two audit fixes:
limit on
fundsOut(vendored ChainlinkRateLimiterinOutflowRateLimiter).RgbSettlementModule.beforeFundsOutverifies every(operationId, amount)pair (existence + exact amount), replacing thesingle-array early-exit logic.
Also drops the now-obsolete R-I-10 pre-fix reproduction test invalidated by the
R-M-01 behavior change.
Why one PR
The R-C-01 and R-M-01 branches were stacked and their sources/tests are
entangled, so they cannot be cleanly separated for the dev-landing. Per-finding
review is preserved by the existing PRs #76/#77/#79/#80.
Base
Stacked on
test/remove-obsolete-executeBatch-repro(restoresdevto acompiling state).