Fix incorrect placement of tot rows sum#321
Open
Arleee1 wants to merge 1 commit intoUVA-LavaLab:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the PIM resource manager where row counts were being double-counted when memory regions were aggregated. The issue occurred because the total row count was updated after region aggregation, causing the aggregated region size (which includes previously counted rows) to be added instead of just the new rows.
Changes:
- Move
m_totRowsInUseincrement to before region aggregation logic incoreUsage::addRange
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, pimAlloc does not update
m_totRowsInUsecorrectly. If a region is aggregated with another region, then the number of rows in the new region is added to the total rows, but the rows in the original region are not subtracted, and thus double counted.This PR fixes the above by adding the number of new rows to
m_totRowsInUsebefore aggregating regions.