Skip to content

Commit 2976a97

Browse files
committed
fix radius scaling tests
1 parent 10e7078 commit 2976a97

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

test/core/test_vector_calculus.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,14 @@ def test_gradient_scales_by_radius(self, gridpath, datasetpath):
152152
grad_unit = uxds["gaussian"].gradient(scale_by_radius=False)
153153

154154
nt.assert_allclose(
155-
grad_scaled["zonal_gradient"], grad_unit["zonal_gradient"] / radius
155+
grad_scaled["zonal_gradient"],
156+
grad_unit["zonal_gradient"] / radius,
157+
equal_nan=True,
156158
)
157159
nt.assert_allclose(
158160
grad_scaled["meridional_gradient"],
159161
grad_unit["meridional_gradient"] / radius,
162+
equal_nan=True,
160163
)
161164

162165

@@ -554,7 +557,7 @@ def test_curl_scales_by_radius(self, gridpath, datasetpath):
554557
curl_scaled = u_component.curl(v_component)
555558
curl_unit = u_component.curl(v_component, scale_by_radius=False)
556559

557-
nt.assert_allclose(curl_scaled, curl_unit / radius)
560+
nt.assert_allclose(curl_scaled, curl_unit / radius, equal_nan=True)
558561

559562
def test_curl_units_and_attributes(self, gridpath, datasetpath):
560563
"""Test that curl preserves appropriate units and attributes"""

uxarray/core/dataarray.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,7 +1418,7 @@ def gradient(self, scale_by_radius: bool = True, **kwargs) -> UxDataset:
14181418
Parameters
14191419
----------
14201420
scale_by_radius : bool, default=True
1421-
Scale derivatives by ``uxgrid.sphere_radius``.
1421+
Divide unit-sphere derivatives by ``uxgrid.sphere_radius``.
14221422
14231423
Returns
14241424
-------
@@ -1474,7 +1474,7 @@ def curl(
14741474
represent the meridional (v) component, while self represents the
14751475
zonal (u) component.
14761476
scale_by_radius : bool, default=True
1477-
Scale derivatives by ``uxgrid.sphere_radius``.
1477+
Divide unit-sphere derivatives by ``uxgrid.sphere_radius``.
14781478
**kwargs : dict
14791479
Additional keyword arguments (currently unused, reserved for future extensions).
14801480

0 commit comments

Comments
 (0)