Fix to_polycollection exclude path: always cache antimeridian_face_indices (#1510)

* Fix to_polycollection exclude path: always cache antimeridian_face_indices

Fixes #1507

When to_polycollection is called without a projection, antimeridian_face_indices
was computed but never written to _poly_collection_cached_parameters, leaving
the cache entry as None. dataarray.to_polycollection then called
np.delete(data, None, axis=0), which became a hard IndexError in numpy 2.0
(previously a silent no-op or deprecation warning).

Move the cache write to before the projection-only block so the entry is always
populated regardless of whether a projection is supplied.

* Restore both cache writes outside projection if-block

PR #1454 accidentally moved both non_nan_polygon_indices and
antimeridian_face_indices cache writes inside the projection check. Move them
back out unconditionally, restoring the pre-#1454 behavior.

Author: rajeeja

uxarray/grid/geometry.py

@@ -507,12 +507,12 @@ def _grid_to_matplotlib_polycollection(
         does_not_contain_nan = ~np.isnan(shells_d).any(axis=(1, 2))
         non_nan_polygon_indices = np.where(does_not_contain_nan)[0]
 
-        grid._poly_collection_cached_parameters["non_nan_polygon_indices"] = (
-            non_nan_polygon_indices
-        )
-        grid._poly_collection_cached_parameters["antimeridian_face_indices"] = (
-            antimeridian_face_indices
-        )
+    grid._poly_collection_cached_parameters["non_nan_polygon_indices"] = (
+        non_nan_polygon_indices
+    )
+    grid._poly_collection_cached_parameters["antimeridian_face_indices"] = (
+        antimeridian_face_indices
+    )
 
     # Select which shells to use: projected or original
     if projected_polygon_shells is not None: