Miscellaneous clean up

* Removed unnecessary usings
* Made `Ubiquity.NET.Extensions.DisposableAction` a class
    * Added ObjectDisposedException in the case of multiple calls to IDispose()
* Renamed `ValidationExtensions` to better reflect intent for fluent extensions.
* Removed RuntimeToolMessages as the only thing left from that is the `MsgLevel` enum, which is moved to `DiagnosticMessage.cs`

Author: smaillet

IgnoredWords.dic

@@ -1,5 +1,6 @@
 ABI
 Accessor
+accessors
 Addr
 addref
 alloca
@@ -72,6 +73,7 @@ Globalization
 Hashtable
 Identifier
 Impl
+initializer
 inline
 inlined
 inlining

src/Samples/CodeGenWithDebugInfo/ITargetABI.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Ubiquity.NET Contributors. All rights reserved.
 // Licensed under the Apache-2.0 WITH LLVM-exception license. See the LICENSE.md file in the project root for full license information.
 
-using System;
 using System.Collections.Immutable;
 
 using Ubiquity.NET.Llvm;

src/Ubiquity.NET.ANTLR.Utils/LocationExtensions.cs

@@ -6,7 +6,6 @@
 using Antlr4.Runtime;
 using Antlr4.Runtime.Tree;
 
-using Ubiquity.NET.Runtime.Utils;
 using Ubiquity.NET.TextUX;
 
 namespace Ubiquity.NET.ANTLR.Utils

src/Ubiquity.NET.Extensions/ByteSpanHelpers.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache-2.0 WITH LLVM-exception license. See the LICENSE.md file in the project root for full license information.
 
 using System;
+using System.Threading;
 
 namespace Ubiquity.NET.Extensions
 {
@@ -11,22 +12,24 @@ namespace Ubiquity.NET.Extensions
     /// valuable when the scope extends beyond a single function (as a return of
     /// <see cref="IDisposable"/>) where a try/finally simply won't work.
     /// </remarks>
-    public readonly record struct DisposableAction
+    public sealed class DisposableAction
         : IDisposable
     {
-        /// <summary>Initializes a new instance of the <see cref="DisposableAction"/> struct.</summary>
+        /// <summary>Initializes a new instance of the <see cref="DisposableAction"/> class.</summary>
         /// <param name="onDispose">Action to run when <see cref="Dispose"/>is called.</param>
         public DisposableAction( Action onDispose )
         {
             OnDispose = onDispose ?? throw new ArgumentNullException( nameof( onDispose ) );
         }
 
-        /// <summary>Runs the action provided in the constructor (<see cref="DisposableAction(System.Action)" /></summary>
+        /// <summary>Runs the action provided in the constructor (<see cref="DisposableAction(System.Action)"/>)</summary>
         public void Dispose( )
         {
-            OnDispose();
+            var disposeOp = Interlocked.Exchange(ref OnDispose, null);
+            ObjectDisposedException.ThrowIf(disposeOp is null, this);
+            disposeOp!();
         }
 
-        private readonly Action OnDispose;
+        private Action? OnDispose;
     }
 }

src/Ubiquity.NET.Extensions/DisposableAction.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.ComponentModel;
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 
@@ -16,14 +17,18 @@ namespace Ubiquity.NET.Extensions
     /// They also serve to provide validation when using body expressions for property
     /// method implementations etc...
     /// </remarks>
-    public static class ValidationExtensions
+    public static class FluentValidationExtensions
     {
+        // NOTE: These DO NOT use the new `extension` keyword syntax as it is not clear
+        //       how CallerArgumentExpression is supposed to be used for those...
+
         /// <summary>Throws an exception if <paramref name="obj"/> is <see langword="null"/></summary>
         /// <typeparam name="T">Type of reference parameter to test for</typeparam>
         /// <param name="obj">Instance to test</param>
         /// <param name="exp">Name or expression of the value in <paramref name="obj"/> [Default: provided by compiler]</param>
         /// <returns><paramref name="obj"/></returns>
         /// <exception cref="ArgumentNullException"><paramref name="obj"/> is <see langword="null"/></exception>
+        [DebuggerStepThrough]
         public static T ThrowIfNull<T>( [NotNull] this T? obj, [CallerArgumentExpression( nameof( obj ) )] string? exp = null )
         {
             ArgumentNullException.ThrowIfNull( obj, exp );
@@ -38,9 +43,11 @@ public static T ThrowIfNull<T>( [NotNull] this T? obj, [CallerArgumentExpression
         /// <param name="max">Maximum value allowed for <paramref name="self"/></param>
         /// <param name="exp">Name or expression of the value in <paramref name="self"/> [Default: provided by compiler]</param>
         /// <returns><paramref name="self"/></returns>
+        [DebuggerStepThrough]
         public static T ThrowIfOutOfRange<T>( this T self, T min, T max, [CallerArgumentExpression( nameof( self ) )] string? exp = null )
             where T : struct, IComparable<T>
         {
+            ArgumentNullException.ThrowIfNull(self, exp);
             ArgumentOutOfRangeException.ThrowIfLessThan( self, min, exp );
             ArgumentOutOfRangeException.ThrowIfGreaterThan( self, max, exp );
 
@@ -59,10 +66,12 @@ public static T ThrowIfOutOfRange<T>( this T self, T min, T max, [CallerArgument
         /// <see cref="FlagsAttribute"/> as a legit value that is a combination of flags does not have
         /// a defined value (Only single bit values do)
         /// </remarks>
+        [DebuggerStepThrough]
         public static T ThrowIfNotDefined<T>( this T self, [CallerArgumentExpression( nameof( self ) )] string? exp = null )
             where T : struct, Enum
         {
-            return Enum.IsDefined<T>( self ) ? self : throw new InvalidEnumArgumentException( exp );
+            ArgumentNullException.ThrowIfNull(self, exp);
+            return Enum.IsDefined( typeof(T), self ) ? self : throw new InvalidEnumArgumentException( exp );
         }
     }
 }

…y.NET.Extensions/ValidationExtensions.cs …Extensions/FluentValidationExtensions.cssrc/Ubiquity.NET.Extensions/ValidationExtensions.cs renamed to src/Ubiquity.NET.Extensions/FluentValidationExtensions.cs src/Ubiquity.NET.Extensions/ValidationExtensions.cs renamed to src/Ubiquity.NET.Extensions/FluentValidationExtensions.cs

@@ -41,6 +41,10 @@ normally used when the value itself isn't passed on but some transformed value i
 * `ThrowIfNotDefined()`
 
 ## PolyFill
-|Fully Qualified Name| Framework requirements |
-|--------------------|-------------|
-|System.Diagnostics.CodeAnalysis.StringSyntaxAttribute`| Target framework is .NET 7 or less. |
+While it isn't `impossible` to make polyfill this to work on .NET standard 2.0 it is a HUGE
+amount of effort to do so and there's no compelling reason to do so. Roslyn extensions/VSIX
+extensions are the most likely candidates left. VS extensions are shifting to external
+processes for extensions for this reason, leaving Roslyn generators. The bottom line is
+that too much of MODERN .NET and C# is incompatible with .NET Standard 2.0 that a distinct
+PolyFill library can only cover some of it. (Even the PolySharp generator covers only
+some of the missing functionality)

src/Ubiquity.NET.Extensions/Readme.md

@@ -29,8 +29,5 @@
         <None Include="ReadMe.md" Pack="true" PackagePath="\" />
     </ItemGroup>
 
-    <ItemGroup>
-        <PackageReference Include="System.IO.Hashing" />
-    </ItemGroup>
 
 </Project>

src/Ubiquity.NET.Extensions/Ubiquity.NET.Extensions.csproj

@@ -3,7 +3,6 @@
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
-using Ubiquity.NET.Llvm.DebugInfo;
 using Ubiquity.NET.Llvm.Instructions;
 using Ubiquity.NET.Llvm.Values;
 

src/Ubiquity.NET.Llvm.Tests/CallTests.cs

@@ -8,6 +8,25 @@
 
 namespace Ubiquity.NET.TextUX
 {
+    /// <summary>Tool Message category</summary>
+    public enum MsgLevel
+    {
+        /// <summary>All channels off</summary>
+        None = 0,
+
+        /// <summary>Verbose messages (or higher) are enabled</summary>
+        Verbose = 1,
+
+        /// <summary>Informational messages (or higher) are enabled.</summary>
+        Information = 2,
+
+        /// <summary>Warning messages (or higher) are enabled. [This is the default value]</summary>
+        Warning = 3, // Default level is warning & error only
+
+        /// <summary>Error messages (or higher) are enabled.</summary>
+        Error = 4,
+    }
+
     /// <summary>Diagnostic message for reporting diagnostics as part of end-user facing experience (UX)</summary>
     /// <remarks>
     /// <see cref="Code"/> must NOT be localized. It is required to universally identify a
@@ -54,7 +73,7 @@ public string Text
             get;
             init
             {
-                ArgumentNullException.ThrowIfNull( value );
+                ArgumentNullException.ThrowIfNull(value);
                 field = value;
             }
         }